<div class="gmail_quote">On Thu, Apr 9, 2009 at 1:02 AM, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#FFFFFF"><div class="im"><div><br></div><div>On Apr 7, 2009, at 9:59 PM, Ben Morgan wrote:<br><br></div><div></div><blockquote type="cite"><div>Hi all,<br><br>Troy committed recently one of my patches which fixed a long-standing bug where e.g. typing Obadiah 20 didn't work as expected. This fixes problems noted around here:<a href="http://www.crosswire.org/pipermail/sword-devel/2000-August/010491.html" target="_blank"><br>
</a><a href="http://www.crosswire.org/pipermail/sword-devel/2000-August/010491.html" target="_blank">http://www.crosswire.org/pipermail/sword-devel/2000-August/010491.html</a><br><br> My original patch had a flag which would enabling parsing Obadiah 20 as Obadiah 1:20, but it was turned off by default. However, when Troy committed it, it was on by default. Personally, I prefer having it off - at the moment, BPBible seems to require it to be off by default.<br>
<br>Previously, code would have been able to get the range for a whole chapter by vk.ParseVerseList("Obadiah 1", "", true). Now this will just go to the verse. This might be a problem in chapter views, etc. Does anyone have any views on which they would prefer?<br>
<br clear="all"></div></blockquote><div><br></div></div>I saw a patch that changed the behavior. Now it knows single chapter books and processes the number as a verse. IMHO this is right. So it will have the impact you note. <div>
</div></div></blockquote><div>This change is quite dangerous, I suspect, to expose as the default, as this will change the behaviour quite substantially. If applications are going to expect to be able to parse Book Chapter as a whole chapter, they won't be able to with this change<br>
<br>BPBible keeps track of whether a verse range to be parsed is user input or not. If it is, it would enable the flag, otherwise it won't.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#FFFFFF"><div><br></div><div>Question: does the book and chapter intros still work? Obad 0:0 and 1:0?</div><div>Or is it now only book intro, as Obad 0?</div><div></div></div></blockquote><div>I think they would still work (though they may not make all that much sense). What this really does is just to parse Obadiah 20 as Obadiah 1:20. The internal representation hasn't changed.<br>
<br><br><br><br><br clear="all">God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>Multitudes, multitudes,<br> in the valley of decision!<br>For the day of the LORD is near<br>
in the valley of decision.<br><br>Giôên 3:14 (ESV)<br>
<br></div></div><br>