<div dir="ltr">Yes, there was a change.<br>I had to change BPBible as well :)<br><br>
>From r2157:<br>
<span style="font-family: courier new,monospace;">Modified: trunk/src/modules/</span><span style="font-family: courier new,monospace;" class="nfakPe">filters</span><span style="font-family: courier new,monospace;">/</span><div id=":17d" class="ArwC7c ckChnd">
<span style="font-family: courier new,monospace;" class="nfakPe">osisfootnotes</span><span style="font-family: courier new,monospace;">.cpp</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
==============================</span><span style="font-family: courier new,monospace;">==============================</span><span style="font-family: courier new,monospace;">=======</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">
--- trunk/src/modules/</span><span style="font-family: courier new,monospace;" class="nfakPe">filters</span><span style="font-family: courier new,monospace;">/</span><span style="font-family: courier new,monospace;" class="nfakPe">osisfootnotes</span><span style="font-family: courier new,monospace;">.cpp 2008-05-13 02:58:16 UTC (rev 2156)</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">
+++ trunk/src/modules/</span><span style="font-family: courier new,monospace;" class="nfakPe">filters</span><span style="font-family: courier new,monospace;">/</span><span style="font-family: courier new,monospace;" class="nfakPe">osisfootnotes</span><span style="font-family: courier new,monospace;">.cpp 2008-05-13 23:37:56 UTC (rev 2157)</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">
@@ -108,7 +108,7 @@</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
hide = false;</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
if (option || (startTag.getAttribute("type") && !strcmp(startTag.getAttribute(</span><span style="font-family: courier new,monospace;">"type"), "crossReference"))) { // we want the tag in the text; crossReferences are handled by another filter</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">
text.append(startTag);</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
- text.append(tagText);</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
+// text.append(tagText);
// we don't put the body back in because it is retrievable from
EntryAttributes["Footnotes"][]</span><span style="font-family: courier new,monospace;">["body"].</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
}</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
else continue;</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">
}</span><br><br>As it says, you can just get the text using getEntryAttributes at the end of the note.<br><br>The way BPBible installs custom filters is by subclassing the MarkupFilterMgr's AddRenderFilters, rather than the SWMgr's<br>
<br>It would be nice if you could pass the filters you wanted used in, though. This would be a pretty common use case...<br></div><br clear="all">God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>
The Lord is not slow to fulfill his promise as some count slowness,<br>
but is patient toward you, not wishing that any should perish,<br>but that all should reach repentance.<br>2 Peter 3:9 (ESV)<br>
<br><br><div class="gmail_quote">On Sun, Jul 27, 2008 at 9:09 PM, Manfred Bergmann <span dir="ltr"><<a href="mailto:bergmannmd@web.de" target="_blank">bergmannmd@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Troy.<br>
<br>
<br>
Am 26.07.2008 um 18:44 schrieb Troy A. Griffitts:<br>
<div><br>
> Do you have:<br>
><br>
> swordManager.setGlobalOption("Cross-references", "On");<br>
><br>
> anywhere in your code?<br>
<br>
</div>Yes.<br>
I just tested a version of MacSword with Sword library 1.5.10 where<br>
the cross ref list (<reference> elements) are placed inside the note<br>
element and are passed to the HTML filter.<br>
Has there been a change for this from 1.5.10 to 1.5.11?<br>
<div><br>
> Yes. You should never have to call AddRenderFilter to a module,<br>
> though<br>
> we do allow you to add your own special filters by overriding the<br>
> virtual SWMgr::AddRenderFilters() method if one of the default SWORD<br>
> filter sets does not work for you. Not sure how MacSword does it now.<br>
<br>
</div>Hmm, we are doing exactly that ATM.<br>
We didn't override AddRenderFilters() in SWMgr but set Filter subclass<br>
instances for every module in a loop via Module::AddRenderFilter().<br>
So the prefered way is to do this via SWMgr::AddRenderFilters().<br>
<div><br>
> The MarkupFilterMgr is the mechanism to ask SWORD to give you a<br>
> specific<br>
> output markup from RenderText(). This code figures out which filter<br>
> set<br>
> to apply to each module depending on the module SourceType (OSIS, GBF,<br>
> ThML, etc...) and will apply the correct filters to meet your<br>
> requested<br>
> output type. But if you can't use any of the default filter sets,<br>
> then<br>
> you'll have to override SWMgr::AddRenderFilters() and apply your<br>
> custom<br>
> filters.<br>
<br>
</div>We did that and used RenderFilters from BibleTime project from 2001.<br>
But I adapted some changes of the current Sword render filters so the<br>
new attributes are checked for additionally to the depricated ones.<br>
<br>
<br>
<br>
Regards,<br>
<font color="#888888">Manfred<br>
</font><div><div></div><div><br>
<br>
_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</div></div></blockquote></div><br></div>