<div class="gmail_quote"><div>Hi.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> If you have a link like sword://KJV/Mark.2.10,14 it will give you a<br>
<div class="Ih2E3d">
> verse list in BibleCS (and you can then click on the individual verses).<br>
> (For some reason, sword://KJV/Mark.2.10,Mark.2.14 does the same, but<br>
> takes the verses to be Mark 2:10 and 2:2, which is probably a bug in the<br>
> verse list parser.)<br>
><br>
</div>Sounds very much like a bug.<br>
<div class="Ih2E3d"></div></blockquote><div><br>It is indeed a bug. The problem is in the parsing logic, and is a problem with using .'s with commas<br>Either of the following variations will work fine:<br>Mark.2.10,Mark 2:14<br>
Mark.2.10;Mark.2.14<br><br>To fix this, the following patch will suffice (I think - but the code is a *tad* messy).<br>Index: src/keys/versekey.cpp<br>===================================================================<br>
--- src/keys/versekey.cpp (revision 2156)<br>+++ src/keys/versekey.cpp (working copy)<br>@@ -669,6 +669,7 @@<br> if (!notAllDigits)<br> break;<br>
<br>+ comma = 0;<br> number[tonumber] = 0;<br> tonumber = 0;<br> if (*number)<br><br>However, even with this patch, the behaviour of the following is unexpected:<br>
Mark.2.10,2.8 -> Mark 2:10, 28<br>
Mark 1 1 -> Mark 11<br>
<br>The code is very messy, and any attempts to change it will probably break it.<br></div></div><br>Also, with the protocol discussion, I think it is worthwhile for each application to have a dedicated protocol, plus be able to use the shared ones. (probably grab them on a first come first served basis?)<br>
So for instance, BPBible might natively use bpbible://KJV/Gen.1.1<br><br>Otherwise systems which rely on the correct one being available (kiosword, and firebible, for example) will be incompatible with each other. This is not a good thing.<br>
<br>Also, if I was specifying a bible protocol, I wouldn't do the version first. I'd do something like bible://Gen.2.5?module=KJV or even bible://Gen.2.5?bible=KJV or bible://Gen.2.5?version=KJV<br>After all, the user is more likely to want to look up a location than to specify which module to use. That should be picked by the application, either based on a user setting, or the last one used.<br>
<br>As to doing it for other books - I like the look of sword://Josephus/The War of the Jews/Book 1/Chapter 2/Section 3 or encoded equivalent. I don't think embedded slashes matter that much - after all, this is what you would expect for a url on a website with well-structured content. This is very easy for users to understand - an advantage if they are bookmarking it.<br>
<br>God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>The Lord is not slow to fulfill his promise as some count slowness,<br>but is patient toward you, not wishing that any should perish,<br>
but that all should reach repentance.<br>2 Peter 3:9 (ESV)