[sword-devel] Major change to osis2mod - Module, NT & OT introductions and bug fixes

[DM Smith]

No, not at all. For a verse, it can use the osisID, say Matt.1 for the sID/eID
<chapter osisID=“Matt.1”> …. </chapter>
becomes
<chapter osisID=“Matt.1” sID=“Matt.1"/>… <chapter osisID=“Matt.1” eID=“Matt.1"/>
rather than:
<chapter osisID=“Matt.1” sID=“ genNNNNNN/>… <chapter osisID=“Matt.1” eID=“genNNNNNN"/>

> On Aug 8, 2025, at 2:21 PM, David Haslam <dfhdfh at protonmail.com> wrote:
> 
> Hi DM,
> 
> Does the last description imply that we are doing away completely with the milestone versions of osisID elements?
> 
> If that's the case, does this overlook a fundamental reason why they were introduced in the first place?
> 
> Does this change warrant some edits to the relevant page in the developers' wiki ?
> 
> 
> Best regards,
> 
> David
> 
> Sent with Proton Mail <https://pr.tn/ref/SWXT9A5YZ67G> secure email.
> 
> 
> On Friday, August 8th, 2025 at 5:29 PM, DM Smith dmsmith at crosswire.org <mailto:dmsmith at crosswire.org> wrote:
> 
> 
> I just checked in the following:
> 
> MODTOOLS-111 osis2mod - Added module and testament introductions.
> * Made div of type bookGroup or book the demarcation between Module Introduction and module content.
> * From John Austin, changed the demarcation of chapter introductions and pre-verse,
> from a section div to a section, subSection or majorSection div when the subType isn't x-introduction.
> ** MODTOOLS-94 subSection pre-verse titles are not recognized
> ** MODTOOLS-95 majorSection titles are not always imported properly- and sometimes drops text
> * Removed old commented out code for majorSection
> * Added two more exit codes EXIT_BAD_COMMENT and EXIT_BAD_ENTITY to replace misuse of EXIT_BAD_NESTING.
> * Reformatted diagnostic messages to be more readable.
> * Used global v11n rather than calling currentVerse.getVersificationSystem().
> * Changed 1 and 0 to true and false where the argument is bool.
> * If the module has module or testament introductions, prepend the revision to the first one, otherwise do as before.
> * Fixed bug where New Testament content is appended to Malachi.
> ** MODTOOLS-4 osis2mod: bug in handling preverse material
> ** MODTOOLS-8 osis2mod does not place the New Testament bookGroup title in the correct place
> ** MODTOOLS-93 New Testament introduction is appended to end of Malachi
> * Rather than generating an sID/eID pair for book, chapter or verse, use the osisID value.
> * updated osis testcases to pass
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20250808/e1e0c2e3/attachment.htm>