[sword-devel] Fwd: cmake patches

[Greg Hellings]

Indeed. It's not a principled stand that I'm refusing to get Subversion
going. It's simply that it's too much work that I haven't bothered and
don't foresee doing so anytime soon.

And, with no setup to automatically test the scripts in all the
environments they must support, it's not likely others are willing to
commit this on my behalf.

--Greg

On Sun, Mar 12, 2023, 09:42 Peter von Kaehne <refdoc at gmx.net> wrote:

> I think you misunderstood Greg.
>
> There is a long campaign and strong feeling to have the project on Git but
> there is no agreement or movement to that. And it seems Greg is pausing his
> contributions until that matter is resolved.
>
> Peter
>
> Sent from my phone. Please forgive misspellings and weird “corrections”
>
> On 12 Mar 2023, at 15:51, ZdPo Ster <zdposter at gmail.com> wrote:
>
> 
> I am sorry, but I did not get the point of your reply.
> I do not use subversion - I use git-svn as proposed several months ago on
> this forum. But current cmake configuration expects everybody to use
> subversion, which is wrong.
> These patches improve cmake build:
>
>    -  that will work also with git-svn
>    - MSVC build
>    - fix depreciated
>
> AFAIK it should cause no harm for other combinations, just improve current
> state.
>
> Zdenko
>
> On Thu, 9 Mar 2023 at 23:18, Greg Hellings <greg.hellings at gmail.com>
> wrote:
>
>> I've never bothered to get Subversion setup on my local machine.
>> Remembering the setup, plus my credentials, and how to use it is more labor
>> than I've been willing to spend on this effort. If, in the future, I
>> overcome that inertia then I'll happily test and apply this patch.
>>
>> --Greg
>>
>> On Sat, Feb 25, 2023 at 5:34 AM ZdPo Ster <zdposter at gmail.com> wrote:
>>
>>> Any update on this (after 3.5 months)?
>>>
>>> Zdenko
>>>
>>> On Sat, 26 Nov 2022 at 21:53, Greg Hellings <greg.hellings at gmail.com>
>>> wrote:
>>>
>>>> Thanks. I am not privy to the patches email inbox, so this mailing list
>>>> is the way to reach me for CMake things. I'll review these when I have the
>>>> opportunity.
>>>>
>>>> --Greg
>>>>
>>>> On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <refdoc at gmx.net> wrote:
>>>>
>>>>>
>>>>> How to suggest improvements to the sword project?
>>>>>
>>>>>
>>>>>
>>>>> You did it the right way. It just is a bit on/off as a project.
>>>>> GHellings is the cmake pumpkin holder as far as I know. I bcc him on a
>>>>> different email address.
>>>>>
>>>>> Peter
>>>>>
>>>>>
>>>>>
>>>>> BR,
>>>>>
>>>>> Zdenko
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: ZdPo Ster <zdposter at gmail.com>
>>>>> Date: Sun, 6 Nov 2022 at 22:22
>>>>> Subject: cmake patches
>>>>> To: <patches at crosswire.org>
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> please find 3 few patches related to cmake build (tested on windows
>>>>> with MSVC 2019):
>>>>>
>>>>>    1. cmake_fix_deprecation.patch - cmake version 3.23.2 produce
>>>>>    depreciation warning for old minimum version, co IMO it is time to increase
>>>>>    expected cmake version
>>>>>    2. cmake_fix_msvc.patch - there is no "/O3" options in current
>>>>>    MSVC[1]
>>>>>    3. cmake_git_svn.patch - I use git svn for accessing code, but
>>>>>    cmake produce error because of missing svn executable. He is patch that
>>>>>    fixed it + code for detecting svn revision (MYSVN_WC_REVISION) from git
>>>>>
>>>>> [1]
>>>>> https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160
>>>>>
>>>>> Zdenko
>>>>>
>>>>> _______________________________________________
>>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>>> http://crosswire.org/mailman/listinfo/sword-devel
>>>>> Instructions to unsubscribe/change your settings at above page
>>>>>
>>>>> _______________________________________________
>>>> sword-devel mailing list: sword-devel at crosswire.org
>>>> http://crosswire.org/mailman/listinfo/sword-devel
>>>> Instructions to unsubscribe/change your settings at above page
>>>>
>>> _______________________________________________
>>> sword-devel mailing list: sword-devel at crosswire.org
>>> http://crosswire.org/mailman/listinfo/sword-devel
>>> Instructions to unsubscribe/change your settings at above page
>>>
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20230317/3954f0f7/attachment.htm>