[sword-devel] Fwd: cmake patches

[ZdPo Ster]

Any update on this (after 3.5 months)?

Zdenko

On Sat, 26 Nov 2022 at 21:53, Greg Hellings <greg.hellings at gmail.com> wrote:

> Thanks. I am not privy to the patches email inbox, so this mailing list is
> the way to reach me for CMake things. I'll review these when I have the
> opportunity.
>
> --Greg
>
> On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <refdoc at gmx.net> wrote:
>
>>
>> How to suggest improvements to the sword project?
>>
>>
>>
>> You did it the right way. It just is a bit on/off as a project. GHellings
>> is the cmake pumpkin holder as far as I know. I bcc him on a different
>> email address.
>>
>> Peter
>>
>>
>>
>> BR,
>>
>> Zdenko
>>
>> ---------- Forwarded message ---------
>> From: ZdPo Ster <zdposter at gmail.com>
>> Date: Sun, 6 Nov 2022 at 22:22
>> Subject: cmake patches
>> To: <patches at crosswire.org>
>>
>>
>> Hello,
>>
>> please find 3 few patches related to cmake build (tested on windows with
>> MSVC 2019):
>>
>>    1. cmake_fix_deprecation.patch - cmake version 3.23.2 produce
>>    depreciation warning for old minimum version, co IMO it is time to increase
>>    expected cmake version
>>    2. cmake_fix_msvc.patch - there is no "/O3" options in current MSVC[1]
>>    3. cmake_git_svn.patch - I use git svn for accessing code, but cmake
>>    produce error because of missing svn executable. He is patch that fixed it
>>    + code for detecting svn revision (MYSVN_WC_REVISION) from git
>>
>> [1]
>> https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160
>>
>> Zdenko
>>
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>>
>> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20230225/2bfc0029/attachment.htm>