[sword-devel] Fwd: cmake patches

ZdPo Ster zdposter at gmail.com
Sat Nov 26 13:11:57 EST 2022


Hello,

I sent attached patches to patches at crosswire.orgbut I got no response.
How to suggest improvements to the sword project?

BR,

Zdenko

---------- Forwarded message ---------
From: ZdPo Ster <zdposter at gmail.com>
Date: Sun, 6 Nov 2022 at 22:22
Subject: cmake patches
To: <patches at crosswire.org>


Hello,

please find 3 few patches related to cmake build (tested on windows with
MSVC 2019):

   1. cmake_fix_deprecation.patch - cmake version 3.23.2 produce
   depreciation warning for old minimum version, co IMO it is time to increase
   expected cmake version
   2. cmake_fix_msvc.patch - there is no "/O3" options in current MSVC[1]
   3. cmake_git_svn.patch - I use git svn for accessing code, but cmake
   produce error because of missing svn executable. He is patch that fixed it
   + code for detecting svn revision (MYSVN_WC_REVISION) from git

[1]
https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160

Zdenko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20221126/41f1fc6e/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_fix_deprecation.patch
Type: application/x-patch
Size: 719 bytes
Desc: not available
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20221126/41f1fc6e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_git_svn.patch
Type: application/x-patch
Size: 4959 bytes
Desc: not available
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20221126/41f1fc6e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_fix_msvc.patch
Type: application/x-patch
Size: 1276 bytes
Desc: not available
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20221126/41f1fc6e/attachment-0002.bin>


More information about the sword-devel mailing list