[sword-devel] Cross references with Sword 1.9.0RC3

[Jaak Ristioja]

Hi!

The respective change in Sword is SVN 3753:

   https://github.com/bibletime/crosswire-sword-mirror/commit/b684b6f099

It seems that this time we were not lucky to have a SWDEPRECATED alias 
for the old function name, silently breaking API, and hence BibleTime.

In theory this silent error could also have been detected in BibleTime 
if we would have used the override keyword. In practice, finding all the 
functions which need the override keyword is for most projects only easy 
to do if the -Wsuggest-override flag (and perhaps even 
-Werror=suggest-override for debug builds) is used. Unfortunately for 
BibleTime (and other projects using Sword), just turning this flag on 
yields very many warnings from Sword headers themselves. The task of 
figuring out how (and when in the build process) to filter 
BibleTime-specific warnings from all warnings is likely not a trivial one.

Best regards,
J

On 18.10.20 01:50, Gary Holmlund wrote:
> I found the issue. BibleTime is using a sword function, 
> AddRenderFilters, which is deprecated. It was renamed to 
> addRenderFilters (A -> a).
> 
> Gary
> 
> On 10/17/20 1:36 PM, Gary Holmlund wrote:
>> I have found that sword is not calling the BibleTime OsisToHtml 
>> filter. It is called with 1.8.1 and not with 1.9RC3. I am still 
>> working on why this does not happen.
>>
>> Gary
>>
>>
>> On 10/16/20 3:49 AM, Troy A. Griffitts wrote:
>>> Hi Gary. No, nothing should have changed in that respect. Can anyone 
>>> else confirm they are having trouble with these in our last RC or svn 
>>> HEAD?
>>>
>>> On October 16, 2020 2:44:32 AM GMT+02:00, Gary Holmlund 
>>> <gary.holmlund at gmail.com> wrote:
>>> >I switched to sword 1.9 rc3 in BibleTime. I am on Fedora 33. Now I have
>>> >
>>> >lost cross references, footnotes, Jesus words, etc.
>>> >
>>> >Did any api for references change? Any other thoughts?
>>> >
>>> >Gary Holmlund
>>> >
>>> >
>>> >_______________________________________________
>>> >sword-devel mailing list: sword-devel at crosswire.org
>>> >http://crosswire.org/mailman/listinfo/sword-devel
>>> >Instructions to unsubscribe/change your settings at above page
>>>
>>> -- 
>>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>>> -- 
>>> Sent from my Android device with K-9 Mail. Please excuse my brevity. 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page