[sword-devel] Win32 FileMgr Subclass - BibleTime

[Greg Hellings]

On Tue, Jul 28, 2020 at 1:02 AM Gary Holmlund <gary.holmlund at gmail.com>
wrote:

>
> On 7/27/20 12:44 PM, Greg Hellings wrote:
>
>
>
> On Mon, Jul 27, 2020 at 3:22 PM Tobias Klein <contact at tklein.info> wrote:
>
>> Maybe it helps: This is how I build bzip2 on Windows with the Visual
>> Studio compiler based on their Git repo *git://sourceware.org/git/bzip2.git
>> <http://sourceware.org/git/bzip2.git>*.
>>
>>
>>
>>
>> https://github.com/tobias-klein/sword-build-win32/blob/master/build_bzip2.bat
>>
>>
>>
>> Best regards,
>> Tobias
>>
>>
>>
>> *From: *Gary Holmlund <gary.holmlund at gmail.com>
>> *Sent: *Montag, 27. Juli 2020 21:01
>> *To: *SWORD Developers' Collaboration Forum <sword-devel at crosswire.org>; Greg
>> Hellings <greg.hellings at gmail.com>
>> *Subject: *Re: [sword-devel] Win32 FileMgr Subclass - BibleTime
>>
>>
>>
>>
>>
>> On 7/27/2020 7:24 AM, Greg Hellings wrote:
>>
>> >
>>
>> > If any other Xiphos developers want to do testing, or if BibleTime
>>
>> > does any cross compiling from Fedora. You can also find Xiphos
>>
>> > installers building the latest Xiphos head against this latest Sword
>>
>> > head. I'm very far from any Windows machine I can use as a test, so if
>>
>> > anyone else has a Windows machine to test this on - preferably one
>>
>> > with a username that includes non-ASCII characters in it - then feel
>>
>> > free to grab that. If the BibleTime Windows builder (Gary?) wants to
>>
>> > generate builds against the latest SVN HEAD and test in the same
>>
>> > manner, it would be a huge help.
>>
>>
>>
>> Greg,
>>
>>
>>
>> I tried to build BibleTime with the latest sword svn, but I ran into a
>>
>> build issue. We don't build with bzip2 because it is not well supported
>>
>> on Windows. I used the cmake var SWORD_NO_BZIP2=Yes, but the sword build
>>
>> still required bzip2. Can you fix this?
>>
>
> Interesting. I was sitting here trying to figure out what you could be
> possibly running into. I don't do my builds with bzip2 installed from MinGW!
>
> Turns out CMakeLists.txt has:
>
> IF(MSVC)
>      FIND_PACKAGE(BZIP2 REQUIRED)
>      FIND_PACKAGE(XZ REQUIRED)
>      FIND_PACKAGE(ICU REQUIRED)
>      FIND_PACKAGE(CURL REQUIRED)
> ELSE(MSVC)
>      FIND_PACKAGE(BZIP2 QUIET)
>      FIND_PACKAGE(XZ QUIET)
>      FIND_PACKAGE(ICU
>                     COMPONENTS data i18n io uc)
>      FIND_PACKAGE(CURL QUIET)
> ENDIF(MSVC)
>
> No issues taking that out, but why would I have make BZip2, XZ, and cURL
> required on MSVC but not for any builds with gcc, even on Windows?
>
> As for its support, I imagine you can use vcpkg to install it? Then you
> don't have to mess with maintaining your own builds.
>
> --Greg
>
>>
>>
>> Gary Holmlund
>>
>> Greg,
>
> I just did a local patch to CMakeLists.txt so I could build BibleTime. I
> built BT 3.0.0-rc1 and tested it with non-ascii home directory. I used
> Visual Studio 2019 and Qt 5.15.0.
>
> I was able to install, read, search, etc. I did not see any problems.
>
> Gary
>

Perfect - I've committed a fix so that it's not forcing you to find any of
those libraries on MSVC.

If you aren't, you might look into the vcpkg tool, though, as I imagine
most of these libraries are able to be found in there. Could reduce your
need to maintain any of the dependencies and make it easier to build with
the optional libs.

--Greg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20200728/71ec6f48/attachment.html>