[sword-devel] Bad markup in VarApp 1.0/bug in Xiphos?

[Karl Kleinpaste]

On 01/23/2016 12:34 AM, Isaac Dunham wrote:
> It consistently shows a sort of 'staircase' effect, as if a superscript
> were being applied but never closed. (See attached screenshot for an
> example.)
> I'm wondering if this is bad markup or a bug, and if it's the latter,
> where the bug is.
The markup is fine. The bug is indeed an erroneous closure of an HTML
<sup> tag, from conversion of the (correct) <hi type="super"> tag. I
fixed this bug in Sword...a long time ago. We are long overdue for a new
Sword release that will include this. Basically, Xiphos displays
whatever the engine generates, and pre-fix, you are seeing the engine error.

The bug was fixed a year ago in January in trunk, and carried into the
1.7.x branch in June.

Index: src/modules/filters/osisxhtml.cpp
===================================================================
--- src/modules/filters/osisxhtml.cpp    (revision 3374)
+++ src/modules/filters/osisxhtml.cpp    (revision 3375)
@@ -617,7 +617,7 @@
                 else if (type == "ol") {
                     outText("</span>", buf, u);
                 }
-                else if (type == "sup") {
+                else if (type == "super") {
                     outText("</sup>", buf, u);
                 }
                 else if (type == "sub") {

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20160123/5735945c/attachment.html>