[sword-devel] AbbottSmith module question

[Jonathan Morgan]

Hi DM,

On Fri, Jan 15, 2016 at 1:40 AM, DM Smith <dmsmith at crosswire.org> wrote:

> I’ve been trawling through the code. Seems that there is support for
> Strong’s Numbers that are not padded. If a module contains Strong’s Numbers
> that are not padded, it is to use StrongsPadding=false. (Actually any value
> other than “true” will be false. TRUE is false.) This module does not have
> it.
>
> Not having StrongsPadding in a conf is the same as StrongsPadding=true.
> There’s a note in the wiki that says that we’ll probably reverse that in
> the future. I doubt it. We still have LZSS as the default compression
> though no module has used it for years (other than experimental modules).
>
> I’m not sure how a Bible with a reference to G0001 will find G1 as it
> doesn’t unpad the user’s input. But at least the dictionary should work.
> BTW, there’s a missing "if (strongsPadding)” in rawLD. It is present in
> zLD. I think this is a bug. Need to verify, report and submit a patch for
> it. (BTW, I don’t have write permissions either on the main repo, but I’m
> not discouraged in contributing and submitting patches.)
>

Sorry if I'm missing something, but surely keys without padding wouldn't
appear in the correct (numeric) order in the dictionary?

Jon


>
> So, I’m guessing that without StrongPadding=true, a lookup for G100,
> becomes G0100 and the nearest entry for it is G1. This might explain the
> infinite loop?
>
> In Him,
> DM
>
> On Jan 13, 2016, at 8:42 PM, DM Smith <dmsmith at crosswire.org> wrote:
>
> Best I can tell, it doesn’t work because the Strong’s number isn’t zero
> filled and I’ve not found any support for Strong’s numbers that aren’t
> padded.
>
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20160116/ea8a8f11/attachment.html>