[sword-devel] IMP format and imp2vs.exe

[DM Smith]

The otherthing that imp2gbs had was detection of empty keys and values. I’ve updated imp2vs to do the same. Also: changed the writeEntry to take the same argument order; changed variable names for the key and entry buffers to match and changed to have a do while loop.

I’m looking at imp2ld, which doesn’t have writeEntry (it should) and doesn’t use FileMgr. It is a bigger change.

— DM

> On Feb 9, 2016, at 8:36 AM, DM Smith <dmsmith at crosswire.org> wrote:
> 
> Troy,
> 
> Would you like me to make the changes? (I’ll take silence as a yes. ;)
> 
> In Him,
> 	DM
> 
>> On Feb 9, 2016, at 4:01 AM, Troy A. Griffitts <scribe at crosswire.org <mailto:scribe at crosswire.org>> wrote:
>> 
>> Hi guys,
>> 
>> Sorry for the delay responding to this thread. My apologies for time which might be wastes.
>> 
>> The intent of imp format was to not require a single line for the entry data. Multiple lines (no need for a continuation \) should be fine.
>> 
>> Looking at all the imp2* utils, imp2gbs uses FileMgr::getLine and adds a \n between lines. This is correct and how the other utils should work. imp2vs does not add the \n and should. imp2ld uses std::getline and does not add a \n and should be changed to use FileMgr calls instead, modeled after imp2gbs.
>> 
>> 
>> 
>> On February 4, 2016 6:25:28 AM MST, Johan Marais <johan.marais at messianic.co.za <mailto:johan.marais at messianic.co.za>> wrote:
>> No problem.
>> 
>> Regards,
>> 
>> Johan Marais
>> Institute for Scripture Research
>> www.messianic.co.za <http://www.messianic.co.za/>
>> 
>> 
>> 
>> -----Original Message-----
>> From: David Haslam [mailto:dfhmch at googlemail.com <mailto:dfhmch at googlemail.com>] 
>> Sent: Thursday, 04 February 2016 2:41 PM
>> To: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
>> Subject: Re: [sword-devel] IMP format and imp2vs.exe
>> 
>> Thanks Johan,
>> 
>> Sorry for omitting the "a" in your first name earlier. :)
>> 
>> More haste, less spood.
>> 
>> David
>> 
>> 
>> 
>> --
>> View this message in context:
>> http://sword-dev.350566.n4.nabble.com/IMP-format-and-imp2vs-exe-tp4655960p46 <http://sword-dev.350566.n4.nabble.com/IMP-format-and-imp2vs-exe-tp4655960p46>
>> 55977.html
>> Sent from the SWORD Dev mailing list archive at Nabble.com <http://nabble.com/>.
>> 
>> 
>> sword-devel mailing list: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
>> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
>> Instructions to unsubscribe/change your settings at above page
>> 
>> 
>> 
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com <http://www.avg.com/>
>> Version: 2016.0.7357 / Virus Database: 4522/11552 - Release Date: 02/04/16
>> 
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com <http://www.avg.com/>
>> Version: 2016.0.7357 / Virus Database: 4522/11552 - Release Date: 02/04/16
>> 
>> 
>> 
>> sword-devel mailing list: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
>> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
>> Instructions to unsubscribe/change your settings at above page
>> 
>> -- 
>> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org <mailto:sword-devel at crosswire.org>
>> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
>> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20160209/f4c35f7a/attachment-0001.html>