[sword-devel] transChange within a rdg element

[DM Smith]

Thanks! I did a quick read of the source looking for other problems. Not seeing anything obvious.

While you have the patient open, would you also add support for <div type=“colophon”> to at least put it on a next line? Outputting it as a <div class=“colophon”> would be one way to do this.

Right now these non-canonical pieces of text are showing as part of the last verse of the last chapter without any distinction that they are different.

— DM
> On Feb 5, 2016, at 12:44 PM, Peter Von Kaehne <refdoc at gmx.net> wrote:
> 
> I must have left it untouched. Sorry. Will fix.
>  
> Gesendet: Freitag, 05. Februar 2016 um 17:37 Uhr
> Von: "DM Smith" <dmsmith at crosswire.org>
> An: "SWORD Developers' Collaboration Forum" <sword-devel at crosswire.org>
> Betreff: Re: [sword-devel] transChange within a rdg element
> SVN head.
>  
> On Feb 5, 2016, at 12:32 PM, Peter Von Kaehne <refdoc at gmx.net <x-msg://368/refdoc@gmx.net>> wrote:
>  
> is this in svn head? Or simply a release?
>  
> Peter
>  
> Gesendet: Freitag, 05. Februar 2016 um 17:10 Uhr
> Von: "DM Smith" <dmsmith at crosswire.org <x-msg://368/dmsmith@crosswire.org>>
> An: "SWORD Developers' Collaboration Forum" <sword-devel at crosswire.org <x-msg://368/sword-devel@crosswire.org>>
> Betreff: Re: [sword-devel] transChange within a rdg element
> At this point the code (osisxhtml) says:
> if ((type == "added") || (type == "supplied"))
>         outText("<span class=\"transChangeSupplied\">", buf, u);
> else if (type == "tenseChange")
>                 buf += "*";
>  
> Note: supplied is not a valid value for transChange and probably represents an earlier OSIS text.
>  
> It really bother’s me that tenseChange is given with mark down. And that none of the other transChange type attributes are passed as class values.
>  
> Here is how it handles catchWord and rdg.
> // <catchWord> & <rdg> tags (italicize)
> else if (!strcmp(tag.getName(), "rdg") || !strcmp(tag.getName(), "catchWord")) {
>         if ((!tag.isEndTag()) && (!tag.isEmpty())) {
>                 outText("<i>", buf, u);
>         }
>         else if (tag.isEndTag()) {
>                 outText("</i>", buf, u);
>         }
> }
>  
> This is not good. Probably should have been <span class=“…”> And catch word should be styled as bold.
>  
> DM
>  
> On Feb 5, 2016, at 11:52 AM, Greg Hellings <greg.hellings at gmail.com <>> wrote:
>  
> At this point, I believe that SWORD hands off styling like that to the
> app to do with CSS (for those apps using HTML output). Does it not? I
> don't thin it's using <i> or <em>, although I could be wrong.
> 
> --Greg
> 
> On Fri, Feb 5, 2016 at 10:26 AM, David Haslam <dfhmch at googlemail.com <>> wrote:
> Something that DM and I have mooted.
> 
> When transChange is used within a rdg element (i.e. inside a note), and
> since SWORD renders text within a rdg as italics, then the text within the
> transChange ought ideally to be rendered as normal type in order to maintain
> the contrast with the other text that's in italics.
> 
> If not already done, please could this be patched in the SWORD source code.
> 
> DM will implement it in JSword.
> 
> Best regards,
> 
> David
> 
> 
> 
> 
> 
> --
> View this message in context: http://sword-dev.350566.n4.nabble.com/transChange-within-a-rdg-element-tp4655995.html <http://sword-dev.350566.n4.nabble.com/transChange-within-a-rdg-element-tp4655995.html>
> Sent from the SWORD Dev mailing list archive at Nabble.com <http://nabble.com/>.
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org <>
> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org <>
> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
> Instructions to unsubscribe/change your settings at above page
> _______________________________________________ sword-devel mailing list: sword-devel at crosswire.org <x-msg://368/sword-devel@crosswire.org> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel> Instructions to unsubscribe/change your settings at above page
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org <x-msg://368/sword-devel@crosswire.org>
> http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel>
> Instructions to unsubscribe/change your settings at above page
> _______________________________________________ sword-devel mailing list: sword-devel at crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel <http://www.crosswire.org/mailman/listinfo/sword-devel> Instructions to unsubscribe/change your settings at above page
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20160205/1de034f9/attachment-0001.html>