[sword-devel] transChange within a rdg element

[DM Smith]

At this point the code (osisxhtml) says:
if ((type == "added") || (type == "supplied"))
        outText("<span class=\"transChangeSupplied\">", buf, u);
else if (type == "tenseChange")
                buf += "*";

Note: supplied is not a valid value for transChange and probably represents an earlier OSIS text.

It really bother’s me that tenseChange is given with mark down. And that none of the other transChange type attributes are passed as class values.

Here is how it handles catchWord and rdg.
// <catchWord> & <rdg> tags (italicize)
else if (!strcmp(tag.getName(), "rdg") || !strcmp(tag.getName(), "catchWord")) {
        if ((!tag.isEndTag()) && (!tag.isEmpty())) {
                outText("<i>", buf, u);
        }
        else if (tag.isEndTag()) {
                outText("</i>", buf, u);
        }
}

This is not good. Probably should have been <span class=“…”> And catch word should be styled as bold.

DM

> On Feb 5, 2016, at 11:52 AM, Greg Hellings <greg.hellings at gmail.com> wrote:
> 
> At this point, I believe that SWORD hands off styling like that to the
> app to do with CSS (for those apps using HTML output). Does it not? I
> don't thin it's using <i> or <em>, although I could be wrong.
> 
> --Greg
> 
> On Fri, Feb 5, 2016 at 10:26 AM, David Haslam <dfhmch at googlemail.com> wrote:
>> Something that DM and I have mooted.
>> 
>> When transChange is used within a rdg element (i.e. inside a note), and
>> since SWORD renders text within a rdg as italics, then the text within the
>> transChange ought ideally to be rendered as normal type in order to maintain
>> the contrast with the other text that's in italics.
>> 
>> If not already done, please could this be patched in the SWORD source code.
>> 
>> DM will implement it in JSword.
>> 
>> Best regards,
>> 
>> David
>> 
>> 
>> 
>> 
>> 
>> --
>> View this message in context: http://sword-dev.350566.n4.nabble.com/transChange-within-a-rdg-element-tp4655995.html
>> Sent from the SWORD Dev mailing list archive at Nabble.com.
>> 
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20160205/60302148/attachment.html>