[sword-devel] SWORD utility Diatheke

[DM Smith]

I don’t think the library is right with regard to headings.

From what I can tell:
a) It will hide canonical headings.
b) It won’t hide non-canonical headings that are not pre-verse.

I’ve been digging through the code and am not certain what I see, but it looks for the first (last?) title or div that is marked x-preverse and bases a decision on whether to show the content based upon that.

Regarding a)

The problem is that the x-preverse is only on the div and is never marked canonical.

The preverse div contains all the inter-verse material that does not belong to the prior verse. Other than titles, all of it should always be shown. Titles should only be always shown if marked canonical.

The titles are not also marked x-preverse. They are within the x-preverse div.

Regarding b)

It only looks for title and div marked x-preverse and does not look for headings within the body of a verse.

Hope this helps.

In Him,
	DM

> On Dec 16, 2015, at 12:54 PM, Peter von Kaehne <refdoc at gmx.net> wrote:
> 
> The library works right. Whether the module is right i do not know.
> 
> Sent from my phone. Apologies for brevity and typos.On 16 Dec 2015 5:06 pm, Greg Hellings <greg.hellings at gmail.com> wrote:
>> 
>> I think the 'canonical="true"' is what's keeping them present. I
>> thought the filters are not supposed to strip out any canonical text,
>> ever.
>> 
>> --Greg
>> 
>> On Wed, Dec 16, 2015 at 10:42 AM, David Haslam <dfhmch at googlemail.com> wrote:
>>> Although one of the diatheke command line options is -h to include Section
>>> Headings, I have found that when using diatheke without this option, the
>>> output still includes the acrostic stanza titles in Psalm 119 (as tested
>>> with the KJV module).
>>> 
>>> Is this a bug or a feature?
>>> 
>>> In the KJV, these titles have OSIS like the following first example:
>>> 
>>> <title canonical="true" type="acrostic"><foreign
>>> n="א">ALEPH.</foreign></title>
>>> 
>>> Best regards,
>>> 
>>> David
>>> 
>>> 
>>> 
>>> --
>>> View this message in context: http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451.html
>>> Sent from the SWORD Dev mailing list archive at Nabble.com.
>>> 
>>> _______________________________________________
>>> sword-devel mailing list: sword-devel at crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>> Instructions to unsubscribe/change your settings at above page
>> 
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page