[sword-devel] Patches to fix compiler warnings

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

As Troy mentioned in an earlier post (and also pointed out to me in
private), the Sword team doesn't count all such warnings as errors. It
is true that most of them are not strictly errors but related to safe
programming style.

However, there are other projects using Swords code (especially the
headers) which have different views and policies about handling
warnings and might specify different -W<warning-type> flags to the
compiler than Sword does.

In BibleTime we've had this problem more than once, that we'd like to
eliminate more compiler warnings, but when we've turned these warnings
on, searching for deficiencies in our code is like finding needles in
the haystack of all the warnings output by Sword headers.

As for finding these errors, I used -Wall Wextra, which I think all
developers should use at least from time to time. The reason is
simple: among these style errors you WILL find real bugs. So did I. So
I still suggest fixing all those non-real-bug warnings so that finding
bugs in the future would not be like searching for needles in a
haystack. It's a little thing, but in the long run it helps the
developer develop much better quality code.

Thanks and blessings,
Jaak


On 21.12.2012 01:32, Jaak Ristioja wrote:
> Hello!
> 
> Please apply these patches (bzip2-ed to workaround sword-devel 90
> KB message size limit and attached) to fix about 3000 compiler
> warnings with GCC and Clang.
> 
> The patches should apply to
> https://crosswire.org/svn/sword/trunk@2751
> 
> Blessings, Jaak
> 
> 
> PS: Here are the sha1sums:
> 
> 7ba3a0b954b8b545d407eb0f46821e4ebdb1c3bf
> sword-Wempty-body-fix.diff.bz2 
> e47776b086c1d8f686a09114bd162358db18a062 
> sword-Wmissing-field-initializers-fix.diff.bz2 
> fc68490a4aac0b8954fa02f0832fdccf95573fd7
> sword-Wtype-limits-fix.diff.bz2 
> eb2749fe94fcb8018be61c8925a12b2503460ac0 
> sword-Wunused-parameter-fix.diff.bz2 
> 004fbd6ac5bf6107cf37beb4b436f34400ec2774 
> sword-comparison-not-assignment-fix.diff.bz2 
> df8231f927ae1c34160b57d7b2a90e58a686448f 
> sword-illegal-source-file-encoding.diff.bz2
> 
> 
> 
> _______________________________________________ sword-devel mailing
> list: sword-devel at crosswire.org 
> http://www.crosswire.org/mailman/listinfo/sword-devel Instructions
> to unsubscribe/change your settings at above page
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQgcBAEBAgAGBQJQ0/8cAAoJEEqsYmEt1rCOzB5AAJ5v2+i2v4yBKZZQ1z+o33pY
lxQDoTmjVb3M+BuI9GpR4g9Ploh1fL2X1aHizfdmuXYIUoszKT0YpPsE5bJTJh0P
Hq81WxIjWXiemSfqVrJ/+gy/Eo1rX09pOmR9gbZwMI3mWWKJDlzMqpzy919pA0x1
0A/s2JxV3uSEZv2Lz6IA9Oe2ujuiMWQRVgF7u2FOppy31tIxP+JxBmRNXoyRaV4l
QHtSvylWR+5Jv8jnwgkkb8GaGFAEX1sv2XBdUsuJIvSZVKZpOG8tce9cjYyhudjJ
oS+ojCiADPVStCP4x+2PumxzQ2KPZiwSKmcES2WVnF0hUQZVVd9eNA6iGOz+rEkb
2Y1ZIaFotcaXR4KeS3p+KqXgprFasFn9IdxIbHwMT05OA60NOTGDb/mcG0k6JKCi
6cJUyOKqF8W6wCbjc2cMQ9aRA8LbUKMjoK/QvTqlb6M4m/VPsGbebZZlbmG/JzZg
uuAh3i62P5R6sBqGsooblMHNrbjWBavEDKuOe/z1E+By2ElWC00VVSLbC/GOX4wP
+3HVxKQD+FC1wDoo374F9UT189D7fFoSCZVj5CSEH4m1vV7q46W8TjIv7tSCowi+
i8/oQg3hZ+Geq+CyI9bdyObu1q7lj7kkqQtMH79HsZMtTz9Uy8VXqwCSNpsew09B
apAMLAfiVTA6ngVQJBcyjZd8IXLNhZ83WLq7nPoHGlqbNHCcqWwUfKKi9brI0AGP
aB1xuj0epxDwZ74FkJuYZssU1mx0TYl7AyKTpX9EC1KzTzv9CfoMEobPlHlcYTv2
owzlON8wwrhF1jTwr2wR3Xv0JR0HNJ2xGDNtuvcRhhpcYoIlQL4AOAZ4fWzzKr9g
aqahqgVSRRg+oCCZ29Om/tSPtrf1j00FPizw+4SEq4Cqa9Et8Jjb7upEHpAhIzgS
4ZKI/6X+WA7fW8XsN/HePM45HEqMAaxrNB9nHUIuS2FG8s8jdB9UddP3rY5ZnYUl
lNXIVaQ1QqiPXGPexhHqg9IZO0N61WqgZsqT0P9/n+vZrAJAHccqjeRrzj+xvDNB
4bdztAlRzlAH+vV4SuVgFf4TVOnm5bTlqcRQliE0fbjL626X56+2WiGKcXu0GYJx
cmzsbf/hVy1B/7kG+LW9Ybf0AyHwhqvYOCFUDBKeh6is4fNYyJ3+kw19pLl6R7PA
vAwc0VvC5e9Jux4SV09LrNNiU4mYQLIJfh1x5QFhzRbuLNZQcAlvM7uwrJHYQLos
mDlwpNtPiGW9UgWXLOaNF4IztoLBNsNAU9o32WrDuYQb0J+Z2Rdfrxae7Z37opIe
TZCgX+Hb92gXhQJ2nD4Cyeq+blYMTPbS7Bzy0odVzasNdCAWcIwNIZe4TPu4xjUZ
DsCzqrLkqaegTSGVJudCTXYY0izs30MhloA+aXETyzjhHjRclvESrKa+lNEabiXY
6HTxOa6veP+r9VkMfLZkrH/z2EYBMqfBXV0gsZ0qnkmRQQjaWJT/Nze+UDIeMCl8
4K2rwRz95DFpU8PA7VU3IGrkeyVOdW2K0Cdkz+fLczy3X64UBHvwud287/1H9tey
rz8U1yTBbitUN1WP/xomHcUlcsZff9KlzFd2sS1xJj7pGTbMF6PCq9/rh1RHTuec
6+swx2ry8Vqyr2n7xHaUJIZaH3x3Tie7peid75LXZ5/H2AeeNVBFGMEUQ9QWKhC1
Md1a+q12mKVQaV4reLVWNNbOcTbLaeC6sDeJ/xORhTAxIDM0ldM2fZDv5bkUO64x
iJxgsgzvCktjYkCKGmZ3qn9mTTAB2e0R/hWjBbAwdt8Rzidpp2y4WQKplp0yd+Lp
AKixj1n2/ttcNSeiuUYgudAEbejDoKQMV2qRmJPGJAXHDmwI2Wkm3HnIQGyvvnD8
QoP0iNMlYxVjn9m1YcZqvd6CH+4+m9gukIJOZlq4GV0RRcA7hLaYcNcAOCh2SAQ4
IUZcuIz2qeifLM0VgZ4Yl6QXxpIidS6p9gnC79X7kgwKroGsxuVeydkj3jP2a2Ri
wAb2m6L6do9NmPlOG0hgofA+SXD+30P80CjvwRqE/GQJJ7CdlfsOzg5mxda7w0UH
YvO+ZVLy6Q2NvsAmIcTbeGquep2fNue1aXuo0WZEYvV5cimYP7xjsrtoOzSTyORx
UflL/7xwuaTj3Zy4bsLcXA2Y+bXw02BWCEISb5ZL6TqQaGpK66X9EdHjxjW7+IoY
QYz6SgtPsY7NrUgLOvyE22FhDfRhHY1TC5lm23AyTZuYF1urfNa/l+nQU19CgUOl
Xk2NkwiuIm83KOPDmaHfS32ESohdFjeYM/koyiXR4bU5GxNsY4KrWSpxzUc8d4kn
TCfzAhLGrL00fMUqlIFyXa+Rn3oYhaZbvxbWNbYIWTLi5rumbaifHVAV6zsvJsln
2AuIGB1gdN9KdFDzLIJB/cL/sYFnncbA3ybdJhAOoRUR35KBtOUikv1mMEH6Ripp
T3srikOeJKqOCGHlqu1bU61UXZ7WBWqf2xgfLt8ts2gNlIMJb+sMZ1XcEREvKuHW
8JDuyHEXke5GV5pfBxWm5Pe3TNY/5d/vN7DeGktmPOgSlKipNylNuNZbBMXsg8sy
wJv9+MHGR6FeOOZJgBnXnWbjJWzvsj+/B63LBvtzC+NQxjcveh8EEzkYvlAT8mn2
1L7Zll9LXtOxy9RgYQ8mCmm1kCYdyVl6V8JdS5zhHhKq/1RPoSgQ7qhPgdzJg9/s
C1lG2DYptqX4Yo9cin6s
=HPHd
-----END PGP SIGNATURE-----