[sword-devel] Submitting a Patch against 1.60svn

[Nathan Anderson]

Troy,	

	Your welcome for the patch.  ;-)

	Well, I might be the _new_ guy; but I don't typically waste my time
trying to patch something and return it up-stream if it isn't broken.  So I
would say yes it is necessary.  ;-)   

	If the class was totally used internally inside "TreeKey" this would
not be a problem (there are several other inner classes that swig complains
about; but because they are used exclusivly internally; the bindings to them
don't matter and the warning can be ignored).

The problem; this code inside versetreekey.h:
	class SWDLLEXPORT VerseTreeKey : public VerseKey, public
TreeKey::PositionChangeListener {

As you can see the "PositionChangeListener" class is not used exclusivly
inside the "TreeKey" class, it is being referenced by another class.  Hence
the broken code it generates since Swig can't generate the code for the
"PositionChangeListener" class we now get broken and uncompilable swig code.

	I can also answer your question about BPBible.  According to their
instructions you need to use v1.5.11 of Sword with the current version of
BPBible.  The change to the VerseTreeKey (which exposes this class),
according to SVN, changed in Rev 2178 on July 20th, 2008 by scribe and this
change is _AFTER_ version 1.5.11 was released.  So, BPBible would be broke
with 1.6 and 1.6-svn.  ;-)    

Nathan.




-----Original Message-----
From: Troy A. Griffitts [mailto:scribe at crosswire.org] 
Sent: Monday, October 19, 2009 4:37 PM
To: SWORD Developers' Collaboration Forum
Subject: Re: [sword-devel] Submitting a Patch against 1.60svn

Thanks for the patch Nathan,

Is this really necessary?  This has been in the code for quite some time and
BPBible has been working with swig bindings for quite some time with this in
the code.  I don't believe this inner class should ever be exposed in the
bindings, as it is a mechanism we use in the implementation of a specific
derived class, and not a basic interface.

Are any of the Morgan's around? :)

	-Troy.



Nathan Anderson wrote:
>  Greg,
> 
> 	Actually the patch is against the Sword library and not the python
> bindings.   The swig library which generates the bindings (for several
> languages) has serious issues with nested classes and a recent change 
> in Sword linrary added a nested class that basically has broke the ability
to
> even make the bindings.   The code attached basically makes the sword
class
> no longer nested.  It should have no impact on anything other than to 
> de-nest the class.  Their may be other nested classes; but in this 
> specific case because the nested class was reference from another 
> class the generated code was broken.
> 
> Nathan.
> 
> -----Original Message-----
> From: Greg Hellings [mailto:greg.hellings at gmail.com]
> Sent: Monday, October 19, 2009 12:03 PM
> To: SWORD Developers' Collaboration Forum
> Subject: Re: [sword-devel] Submitting a Patch against 1.60svn
> 
> You can send it to the mailing list.  The Python bindings are 
> maintained primarily by the BPBible team, from what I understand, so 
> you can also get in touch with them for more help on the binding
specifically.
> 
> --Greg
> 
> On Mon, Oct 19, 2009 at 11:52 AM, Nathan Anderson 
> <nathan at andersonsplace.net> wrote:
>>        Is their someone I can/should send a patch to that fixes the 
>> python swig bindings issues in 1.6/1.6svn.    Or do I send it to the
> mailing list?
>> Nathan
>>
>>
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org 
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>>
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org 
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
> 
> 
> ----------------------------------------------------------------------
> --
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org 
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page


_______________________________________________
sword-devel mailing list: sword-devel at crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page