[sword-devel] Updated regex.patch

[Troy A. Griffitts]

Dima and Matthew,

Thank you guys for working on this!  Any final status on the situation?

Dima, could you explain to me the changes you've made with regard to
changing:

-INCLUDES = -I $(top_srcdir)/include
+include $(top_srcdir)/include/Makefile.am


I'm no configure expert and so this looks very different to me.
The first seems to add a -I sword/include to the include path during
compile.
The second seems to include the include/Makefile.am during autoconf
processing.

Again, I'm ignorant to these matters, but just wanted us to check before
committing code that might not be related to the problem at hand and
might break something else right before a release.

Thanks for bearing with my scrutiny.

Troy


On 12/16/2009 08:49 PM, Matthew Talbert wrote:
> On Wed, Dec 16, 2009 at 8:55 PM, Dmitrijs Ledkovs
> <dmitrij.ledkov at gmail.com> wrote:
>   
>> This time around when searching for regex it will add additional
>> -llibrary flags if required.
>>
>> For example on my linux it doesn't add any (prints none required) on
>> windows it should add a flag.
>>
>>     
> This works fine with MSYS when you have a shared library. It does not
> work when you are expecting to use SWORD's internal library. This is
> because lib/Makefile has a line am__objects_3 = regex.lo which is
> always commented out. This is the same problem that the build system
> has always had at this point. I do not know why this is. I'm still
> looking into it, but any suggestions would be great.
>
> Matthew
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>