[sword-devel] Mingw and SWORD's internal regex (was: Re: 1.6.1 outstanding items? )

[Troy A. Griffitts]

Do we need a further resolution to this?  I can maybe add a check:

AC_SEARCH_LIBS(regcomp)

to see if we can find a system-wide regex lib and if so use it,
otherwise use the internal SWORD regex, but then we'd use the
system-wide one if it existed, instead of any enhanced regex lib someone
might want to use...

I supposed we could just let the user specify they need the internal one
manually if they need it:

--with-internal-regex

But then people will need to specify it if they don't have a systemwide
regex.

Maybe a check and include internal regex if we need it, and also a
--without-internal-regex which will exclude no matter what the check
says?  Then you could force it to exclude no matter what so you could
use your custom regex lib.

Guess I'm just thinking out loud.

Suggestions on the resolution?

Troy



On Thu, 2009-12-03 at 20:10 -0500, Matthew Talbert wrote:
> > Did you file a bug report about that? :)
> 
> Well, when I finally figured out what was going on, I realized I could
> link to a different copy of regex, so it didn't affect me any longer.
> 
> > It should work now... I'm pretty sure I tested it that far under Mingw as
> > well as under Ubuntu and Debian, back when I made the change :)
> 
> Yea, what I'm afraid of is that it works :) I haven't tested it yet.
> 
> > But if no-one wants to use the SWORD regex at all, then logically this
> > should be removed from the source tree completely and not tested for :)
> >
> >> What I would like to see is a test for -lregex rather than mingw. That
> >> would satisfy all use cases and make things easier for me. I have
> >> available a regex lib which is more up-to-date than sword's copy, plus
> >> it's a dependency for Xiphos anyway, so I'd rather use it. A simple
> >> test for the regex lib would be sufficient.
> >
> > Sounds reasonable if there is actually still a use case where someone *does*
> > want to use the SWORD-supplied regex code (BTW, if they do, can it be kept
> > updated, please?).  Embedded platforms, maybe?  If there is in fact no such
> > use case at all, then I vote for removing the unwanted code, and just
> > requiring an externally-supplied regex library -- keep it simple :)
> 
> I believe that building with Visual Studio probably still uses the
> code. It would also help if someone is using mingw and doesn't know
> about the availability of other regex libraries.
> 
> Matthew
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page