[sword-devel] ESV linegroups not processed in osishtmlhref

[Greg Hellings]

On Thu, Apr 30, 2009 at 1:35 AM, Ben Morgan <benpmorgan at gmail.com> wrote:
> The ESV has linegroups of the style <lg sID="..."> and <lg eID="...">, but
> these aren't picked up by osishtmlhref.
> It has a rule to change <lg> and </lg> into <br />, but none for lg's with
> attributes.

When you say "with attributes" are you referring specifically to the
s/eID attributes?  As you say, adding the case for that isn't terribly
difficult.  What is more difficult, in my mind, is to know how to
properly adjust that into good HTML.

What is the module creator usually trying to convey by the presence of
the lg tags?  I'm guessing it's mainly poetry and <lg> is for things
like stanzas?  In that case the <P> tag seems to make the most sense
in my mind, rather than a <BR/>.  Both the appearance (a group of text
off-set from the preceding and succeeding text) and the semantics (a
group of elements which are semantically close to one another but
further from the surrounding text) of the <P> tag seem the most
logical fit.  Although a <DIV> seems close, if <lg> is being used for
non-text items also.

Adding the case can be a quick no-brainer and most anyone of the C++
capable people on this list could get a patch together if you knew
what you wanted them to be and knew for sure they weren't being
handled by the code that deals with the container forms.

--Greg

> This would be reasonably simple to add - just another case in the token
> handling (rather than relying on token substitution).
>
> A while ago, Daniel Owens and I were talking about the use of linegroups in
> VietNVB. Daniel had removed the linegroups as they caused a new line to
> appear after the versenumber in (I think) Xiphos - and he noticed this
> didn't happen with the ESV's linegroups. I now wonder whether this was
> because the ESV didn't output the <br /> at the start of line groups, due to
> the sID and eID elements. If so, perhaps <br /> shouldn't be output? (BTW,
> linegroups are important to retain intact, so I don't want them to be
> eliminated from the module...)
>
> God Bless,
> Ben
> -------------------------------------------------------------------------------------------
> Multitudes, multitudes,
>    in the valley of decision!
> For the day of the LORD is near
>    in the valley of decision.
>
> Giôên 3:14 (ESV)
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>