[sword-devel] key parse failure, -r2304

[Ben Morgan]

Bug in diatheke. ParseVerseList may now return unbounded versekeys, diatheke
assumed that if there was a versekey, it was bounded.

I've fixed this in r2306.

God Bless,
Ben
-------------------------------------------------------------------------------------------
Multitudes, multitudes,
   in the valley of decision!
For the day of the LORD is near
   in the valley of decision.

Giôên 3:14 (ESV)



On Thu, Apr 9, 2009 at 5:12 AM, Troy A. Griffitts <scribe at crosswire.org>wrote:

> Thanks Karl.  There have been some changes in verse parsing lately that I'm
> not positive we've considered all the repercussions.  We need to add some
> more tests to our testsuite, specifically versekeytest.cpp to be sure things
> operate correctly now and in the future.
>
> Any chance we can get a simple test added to the top that shows the issue?
>  It will be a little easier to debug than with diatheke, and will give us a
> good mark to be sure we hit with future changes.
>
>        -Troy.
>
>
>
> Karl Kleinpaste wrote:
>
>> I asked for just one verse.
>>
>> $ svn info | grep ^Rev
>> Revision: 2304
>> $ time ./utilities/diatheke/diatheke -b KJV -k Gen1.1 > /tmp/kjv-gen1.1
>> 61.594u 0.869s 1:02.86 99.3%    0+0k 0+9040io 0pf+0w
>> $ wc /tmp/kjv-gen1.1
>>  44123  862024 4628222 /tmp/kjv-gen1.1
>> $ head /tmp/kjv-gen1.1
>> [ Module Heading ]: [ Testament 1 Heading ]: Genesis 0:0: Genesis 1:0:
>> Genesis 1:1: In the beginning God created the heaven and the earth.
>> Genesis 1:2: And the earth was without form, and void; and darkness was
>> upon the face of the deep. And the Spirit of God moved upon the face of the
>> waters.
>> Genesis 1:3: And God said, Let there be light: and there was light.
>> Genesis 1:4: And God saw the light, that it was good: and God divided the
>> light from the darkness.
>> Genesis 1:5: And God called the light Day, and the darkness he called
>> Night. And the evening and the morning were the first day.
>>
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20090409/b7cb6115/attachment.html>