[sword-devel] problems with osis filters?

[Greg Hellings]

Martin,

On Tue, Dec 9, 2008 at 2:27 PM, Martin Gruner <mg.pub at gmx.net> wrote:
> Hi all.
>
> I've got problems with Sword 1.5.11, which seem not to be present with 1.5.9.
>
> martin at workstation:/home/dev/sword/examples/cmdline$ ./lookup ESV "3Joh 1:1"
> ==Raw=Entry===============
> III John 1:1:
> <title subType="x-preverse" type="section">Greeting</title><note n="a"
> osisID="3John.1.1!crossReference.a" osisRef="3John.1.1"
> type="crossReference"><reference osisRef="2John.1.1">2 John
> 1</reference></note>The elder to the beloved Gaius, <note n="b"
> osisID="3John.1.1!crossReference.b" osisRef="3John.1.1"
> type="crossReference"><reference osisRef="1John.3.18">1 John 3:18</reference>;
> <reference osisRef="2John.1.1">2 John 1</reference></note>whom I love in
> truth. <lb type="x-end-paragraph"/> <lb type="x-begin-paragraph"/>
> ==Render=Entry============
> <a
> href="passagestudy.jsp?action=showNote&type=x&value=1&module=ESV&passage=III+John+1%3A1"><small><sup>*x</sup></small></a>The
> elder to the beloved Gaius, <a
> href="passagestudy.jsp?action=showNote&type=x&value=2&module=ESV&passage=III+John+1%3A1"><small><sup>*x</sup></small></a>whom
> I love in truth. <br /><br />
> ==========================
>
> (Output from Sword SVN, seems to be  same behaviour as 1.5.11)
>
> Please look at how the <reference> tags inside the <note> tag disappear in the
> rendered output.
>
> At BibleTime, we use an OSISHTMLHREF descendant class for the filtering of some
> tags. Now it seems that handleToken() does not even get called for the
> <reference> and </reference> tags. One call is for <note>, and the next
> already for </note>. Their content is skipped.
> This does not seem to be the case with Sword 1.5.9, but I could not find out
> what causes this.

I observed some similar behaviors and took action to deal with a few
of the unhandled tags.  I know there was an issue with note handling
in OSIS, but I'm not sure if that is in the patch I submitted the
other day or not.  Troy or Chris said they'd hopefully get to it in
the next week.  Adding support for the tags isn't usually very
difficult, provided there is a straightforward 1:1 mapping into
HTMLHREF.  But I did make a few changes to some of the filters and if
there are other people making additions, it's probably time to at
least shuffle a 1.5.12 out the door, and maybe talk about naming it
1.6 or something like that to incorporate the other changes?

--Greg