[sword-devel] Bug in sword 1.5.7

Hugo van der Kooij sword-devel@crosswire.org
Sat, 10 Jan 2004 11:49:45 +0100 (CET)


On Sat, 10 Jan 2004, Hugo van der Kooij wrote:

> I noticed a bug in the makefile for sword 1.5.7
>
> The install_config phase has a hardcoded path to /etc/ instead of the
> sysconfdir variable that should have been used.

After final tests I made the following patch:

--- sword-1.5.7/Makefile.in.OLD 2003-12-26 06:55:43.000000000 +0100
+++ sword-1.5.7/Makefile.in     2004-01-10 10:37:45.000000000 +0100
@@ -879,8 +879,8 @@
        @echo ""

 install_config:
-       @echo "[Install]" > /etc/sword.conf
-       @echo "DataPath=$(pkgdatadir)/" >> /etc/sword.conf
+       @echo "[Install]" > $(sysconfdir)/sword.conf
+       @echo "DataPath=$(pkgdatadir)/" >> $(sysconfdir)/sword.conf
        @echo "sword.conf generated"
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.

Now the sysconfdir variable can be used to control the package building.
An updates RPM set have been created using this new patch which now builds
clean for common users as well.

Hugo.

-- 
 All email sent to me is bound to the rules described on my homepage.
    hvdkooij@vanderkooij.org		http://hvdkooij.xs4all.nl/
	    Don't meddle in the affairs of sysadmins,
	    for they are subtle and quick to anger.