<div dir="ltr">Shouldn&#39;t this include something more like &lt;h3 class=&quot;title&quot;&gt;, in an effort to include more class-based information in the output of our filters to facilitate rendering?<div><div><br></div>
<div>--Greg</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 15, 2014 at 4:27 PM,  <span dir="ltr">&lt;<a href="mailto:scribe@crosswire.org" target="_blank">scribe@crosswire.org</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: scribe<br>
Date: 2014-04-15 14:27:54 -0700 (Tue, 15 Apr 2014)<br>
New Revision: 3155<br>
<br>
Modified:<br>
   trunk/src/modules/filters/osisheadings.cpp<br>
Log:<br>
Made consistent the handling of old school preverse titles and the newer<br>
preverse divs.  They both include the &lt;title&gt; tags now for titles, so<br>
fronends need to stop wrapping preverse headings with &lt;h3&gt; or whatever<br>
the do to make it stand off as a title.  The &lt;title&gt; tag will process as<br>
any other title tag now.<br>
<br>
Modified: trunk/src/modules/filters/osisheadings.cpp<br>
===================================================================<br>
--- trunk/src/modules/filters/osisheadings.cpp  2014-04-15 20:27:07 UTC (rev 3154)<br>
+++ trunk/src/modules/filters/osisheadings.cpp  2014-04-15 21:27:54 UTC (rev 3155)<br>
@@ -91,6 +91,8 @@<br>
                if (name == u-&gt;currentHeadingName) {<br>
                        if (tag.isEndTag(u-&gt;sID)) {<br>
                                if (!u-&gt;depth-- || u-&gt;sID) {<br>
+                                       // see comment below about preverse div changed and needing to preserve the &lt;title&gt; container tag for old school pre-verse titles<br>
+                                       if (u-&gt;currentHeadingName == &quot;title&quot;) u-&gt;heading.append(tag);<br>
                                        // we&#39;ve just finished a heading.  It&#39;s all stored up in u-&gt;heading<br>
                                        bool canonical = (SWBuf(&quot;true&quot;) == u-&gt;currentHeadingTag.getAttribute(&quot;canonical&quot;));<br>
                                        bool preverse = (SWBuf(&quot;x-preverse&quot;) == u-&gt;currentHeadingTag.getAttribute(&quot;subType&quot;) || SWBuf(&quot;x-preverse&quot;) == u-&gt;currentHeadingTag.getAttribute(&quot;subtype&quot;));<br>

@@ -130,7 +132,16 @@<br>
<br>
                u-&gt;currentHeadingName = name;<br>
                u-&gt;currentHeadingTag = tag;<br>
-               u-&gt;heading = &quot;&quot;;<br>
+               // leave the actual &lt;title...&gt; wrapper in if we&#39;re part of an old school preverse title<br>
+               // because now frontend have to deal with preverse as a div which may or may not include &lt;title&gt; elements<br>
+               // and they can&#39;t simply wrap all preverse material in &lt;h1&gt;, like they probably did previously<br>
+               if (name == &quot;title&quot;) {<br>
+                       XMLTag wrapper = tag;<br>
+                       if (SWBuf(&quot;x-preverse&quot;) == wrapper.getAttribute(&quot;subType&quot;)) wrapper.setAttribute(&quot;subType&quot;, 0);<br>
+                       else if (SWBuf(&quot;x-preverse&quot;) == wrapper.getAttribute(&quot;subtype&quot;)) wrapper.setAttribute(&quot;subtype&quot;, 0);<br>
+                       u-&gt;heading = wrapper;<br>
+               }<br>
+               else    u-&gt;heading = &quot;&quot;;<br>
                u-&gt;sID = u-&gt;currentHeadingTag.getAttribute(&quot;sID&quot;);<br>
                u-&gt;depth = 0;<br>
                u-&gt;suspendTextPassThru = true;<br>
<br>
<br>
_______________________________________________<br>
sword-cvs mailing list<br>
<a href="mailto:sword-cvs@crosswire.org">sword-cvs@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-cvs" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-cvs</a><br>
</blockquote></div><br></div>