[osis-core] Revision/Bug Fix proposal

[Todd Tillinghast]

> 
> Harry, I know you use divType, do you use any of the other named types
> like noteType? I can run sed scripts to fix the files.
> 
> Guys,
> 
> I had a long discussion with Steve on the <qStart>, <qEnd>, divType,
> noteType, etc. issues:
> 
> Suggested fix (read all of it before objecting (more of a note to
myself
> that any of you)):
> 
> 1. Change all type attributes, including divType and noteType to type.
> 
> 2. Will have commonWithType and commonWithoutType attribute classes.
> 
> 3. Elements that now have enumerated types, like <div> will have
> commonWithoutType and its "type" attribute will point to "divType"
which
> is already in place, so fewer typing errors. Same for <note>
> 

Sounds cleaner to me.

> 4. Drop <qEnd> and <qStart>.
> 
> 5. milestoneStart and milestoneEnd, get commonWithType, and we add who
> and level to their attributes. (gathered from the other elements that
> are enumerated for the milestoneSE values. Any others that are
peculiar
> to those elements that we should add to milestoneStart and
milestoneEnd?)

This does solve the <qStart> and <qEnd> problem but is a VERY ugly
precedent to start.  Are we going to add in more attributes that make
sense in only some applications to support other needs in the future?

I prefer a clean generic milestone and a few special purpose milestones
over an UGLY generic milestone loaded down with a number of attributes.
I vote to keep <qStart> and <qEnd>.

In any case, I hope the "end" and "start" attributes are still present
in the new version of milestoneStart and milestoneEnd.

> 
> This sets a precdence for adding attributes for milestones for cases
> where they must substitute for other elements, as opposed to new types
> of milestones so it can have the proper attributes for that element.
> 
> Looks a lot cleaner to me and my only concern is breakage of Harry's
> texts, but I think sed may have the answer to that.
> 
> BTW,  we are going to be recommended on Monday to a rather large group
> of bible scholars. (Just want you to know that your efforts are
noticed,
> appreciated and are having a positive impact. Sorry I can reward
> everyone more tangibly than that at the moment. Sigh. Perhaps I will
> find a winning lottery ticket!)
> 
> So I don't have to break my fingers typing when the flood of +1's come
> in, I will be working on revising the latest release in a separate
> directory just so I will be ready.
> 
> Patrick
> 
> --
> Patrick Durusau
> Director of Research and Development
> Society of Biblical Literature
> pdurusau@emory.edu
>