[jsword-svn] jsword/java/jsword/org/crosswire/jsword/book/filter/osis s

[jswordcvs at crosswire.org]

Update of /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/filter/osis
In directory www.crosswire.org:/tmp/cvs-serv6194/java/jsword/org/crosswire/jsword/book/filter/osis

Modified Files:
	OSISFilter.java 
Log Message:
Moved unused code to limbo.
Upgraded support-tools: checkstyle, pmd and findbugs to most recent.
Addressed over 100 issues reported by findbugs and checkstyle.
Resulted in major refactoring of GBFFilter.
Net result is that code size is significantly smaller.

Index: OSISFilter.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/filter/osis/OSISFilter.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** OSISFilter.java	6 Mar 2005 18:13:28 -0000	1.13
--- OSISFilter.java	9 May 2005 01:29:08 -0000	1.14
***************
*** 85,91 ****
                      try
                      {
!                         Element p = OSISUtil.factory().createP();
!                         ele.addContent(p);
!                         p.addContent(plain);
                      }
                      catch (Exception ex4)
--- 85,90 ----
                      try
                      {
!                         ele = OSISUtil.factory().createP();
!                         ele.addContent(plain);
                      }
                      catch (Exception ex4)
***************
*** 98,101 ****
--- 97,104 ----
          finally
          {
+             if (ele == null)
+             {
+                 ele = OSISUtil.factory().createP();
+             }
              // Make sure that other places don't report this problem
              DataPolice.setKey(null);