[jsword-svn] jsword/java/jsword/org/crosswire/jsword/book/filter/thml s

jswordcvs at crosswire.org jswordcvs at crosswire.org
Sun May 8 18:29:11 MST 2005


Update of /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/filter/thml
In directory www.crosswire.org:/tmp/cvs-serv6194/java/jsword/org/crosswire/jsword/book/filter/thml

Modified Files:
	THMLFilter.java 
Log Message:
Moved unused code to limbo.
Upgraded support-tools: checkstyle, pmd and findbugs to most recent.
Addressed over 100 issues reported by findbugs and checkstyle.
Resulted in major refactoring of GBFFilter.
Net result is that code size is significantly smaller.

Index: THMLFilter.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jsword/org/crosswire/jsword/book/filter/thml/THMLFilter.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -d -r1.14 -r1.15
*** THMLFilter.java	6 Mar 2005 18:13:28 -0000	1.14
--- THMLFilter.java	9 May 2005 01:29:07 -0000	1.15
***************
*** 91,104 ****
                      log.warn("Could not fix it by cleaning tags: " + ex3.getMessage()); //$NON-NLS-1$
  
!                     try
!                     {
!                         Element p = OSISUtil.factory().createP();
!                         ele.addContent(p);
!                         p.addContent(plain);
!                     }
!                     catch (Exception ex4)
!                     {
!                         log.warn("no way. say it ain't so! " + ex4.getMessage()); //$NON-NLS-1$
!                     }
                  }
              }
--- 91,96 ----
                      log.warn("Could not fix it by cleaning tags: " + ex3.getMessage()); //$NON-NLS-1$
  
!                     ele = OSISUtil.factory().createP();
!                     ele.addContent(plain);
                  }
              }
***************
*** 106,109 ****
--- 98,106 ----
          finally
          {
+             if (ele == null)
+             {
+                 ele = OSISUtil.factory().createP();
+                 ele.addContent(plain);
+             }
              // Make sure that other places don't report this problem
              DataPolice.setKey(null);



More information about the jsword-svn mailing list