[jsword-svn] jsword/java/jswordtest/org/crosswire/jsword/passage s

[jswordcvs at crosswire.org]

Update of /cvs/jsword/jsword/java/jswordtest/org/crosswire/jsword/passage
In directory www.crosswire.org:/tmp/cvs-serv6194/java/jswordtest/org/crosswire/jsword/passage

Modified Files:
	PassageParentTst.java VerseRangeTest.java 
Log Message:
Moved unused code to limbo.
Upgraded support-tools: checkstyle, pmd and findbugs to most recent.
Addressed over 100 issues reported by findbugs and checkstyle.
Resulted in major refactoring of GBFFilter.
Net result is that code size is significantly smaller.

Index: PassageParentTst.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jswordtest/org/crosswire/jsword/passage/PassageParentTst.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** PassageParentTst.java	25 Aug 2004 22:54:37 -0000	1.9
--- PassageParentTst.java	9 May 2005 01:29:06 -0000	1.10
***************
*** 398,403 ****
          assertEquals(keyf.getKey("").toString(), ""); //$NON-NLS-1$ //$NON-NLS-2$
          assertEquals(keyf.getKey("gen 1 1-50:26,e,e 1 2,e 1 3-10").toString(), "Gen-Exo"); //$NON-NLS-1$ //$NON-NLS-2$
!         try { keyf.getKey(null); fail(); }
!         catch (NullPointerException ex) { }
      }
  
--- 398,402 ----
          assertEquals(keyf.getKey("").toString(), ""); //$NON-NLS-1$ //$NON-NLS-2$
          assertEquals(keyf.getKey("gen 1 1-50:26,e,e 1 2,e 1 3-10").toString(), "Gen-Exo"); //$NON-NLS-1$ //$NON-NLS-2$
!         assertEquals(keyf.getKey(null).toString(), "");  //$NON-NLS-1$
      }
  

Index: VerseRangeTest.java
===================================================================
RCS file: /cvs/jsword/jsword/java/jswordtest/org/crosswire/jsword/passage/VerseRangeTest.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -d -r1.10 -r1.11
*** VerseRangeTest.java	30 Aug 2004 09:27:08 -0000	1.10
--- VerseRangeTest.java	9 May 2005 01:29:06 -0000	1.11
***************
*** 144,148 ****
          catch (NoSuchVerseException ex) { }
          try { VerseRangeFactory.fromString((String) null); fail(); }
!         catch (NullPointerException ex) { }
          assertEquals(gen_all, VerseRangeFactory.fromString("Gen")); //$NON-NLS-1$
          assertEquals(rev99_9, VerseRangeFactory.fromString("Rev 22")); //$NON-NLS-1$
--- 144,148 ----
          catch (NoSuchVerseException ex) { }
          try { VerseRangeFactory.fromString((String) null); fail(); }
!         catch (NoSuchVerseException ex) { }
          assertEquals(gen_all, VerseRangeFactory.fromString("Gen")); //$NON-NLS-1$
          assertEquals(rev99_9, VerseRangeFactory.fromString("Rev 22")); //$NON-NLS-1$