<div dir="ltr">The main issue is not related to the osisRef attribute but to the content of the reference tag - '<span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap">muqaddas</span>' - being excluded by <span style="font-size:12.8px">getCanonicalText() and AB code. The problem here is quite significant because it would appear to users as though some words had been removed from the Bible. I wanted to check that by including reference tag content I should not be breaking anything else. In the normal AB Bible view the ref tag content is properly displayed but in certain secondary views where simple text is required e.g. when messaging, references are currently ignored.</span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">There may be another issue with the above example, because of the complexity of the osisRef attribute but that is not John's primary concern. Although I believe John has raised an issue regarding multiple refs in an osisRef before. iirc AB just uses the first ref, which also isn't perfect.</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Martin</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 27 November 2015 at 23:40, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’d have to look into this carefully to see why it is being dropped. I think the xslt expects references to be in a note. From memory, a reference that is not within a note is treated as inline text.<div><div><br></div><div>Also there is no support for non-biblical references at this time. It should recognize the work part of the reference, what’s before the colon, as the module name. We’ve never supported types of x- that were not generated by JSword. If the type of the work needs to be communicated, it probably should be something like osisRef=“Dictionary.UZDOTL:….” In the absence of that we should look to see if there is a book with those Initials and determine the type from the MetaData.</div><div><br></div><div>In this example the osisRef is to 2 different works. Not sure how that should work. Two lookups?</div><div><div><br></div><div>The other thing is that we have a toggle for references that merely toggles whether the reference is a link. Not sure how a reference can be to two different things.</div></div><div><br></div><div>My guess as to what is happening: It tries to parse the reference as a Bible reference, gets an exception and doesn’t show anything.</div><div><br></div><div>DM</div><div><br><div><blockquote type="cite"><div><div class="h5"><div>On Nov 27, 2015, at 4:31 PM, Martin Denham <<a href="mailto:mjdenham@gmail.com" target="_blank">mjdenham@gmail.com</a>> wrote:</div><br></div></div><div><div><div class="h5"><div dir="ltr">John has raised <a href="https://github.com/mjdenham/and-bible/issues/46" target="_blank">this issue</a> regarding the content of reference tags being removed in And Bible under certain circumstances and this has highlighted a possible flaw both in JSword and And Bible code.<div><br></div><div>The full details are in <a href="https://github.com/mjdenham/and-bible/issues/46" target="_blank">this issue</a> but are summarised below. I am not an OSIS expert so really would just like confirmation of my understanding.</div><div><br></div><div>In the following extract from UZVL the reference content 'muqaddas' is being excluded both by JSword's OSISUtil.getCanonicalText and by certain And Bible code and I wish to confirm this is a bug:</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap"><verse sID="Gen.2.3" osisID="Gen.2.3"/>Xudo yettinchi kuni barcha<br></span><span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap">yaratish ishlaridan dam olgani uchun, bu kunni muborak qilib, <reference<br></span><span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap">type="x-glossary" osisRef="UZDOTL:MUQADDAS<br></span><span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap">UZDNTL:MUQADDAS">muqaddas</reference>, deb boshqa kunlardan<br></span><span style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:21px;white-space:pre-wrap">ajratdi.</p><verse eID="Gen.2.3"/></span></blockquote><div><br></div><div>My current understanding is that a reference may or may not contain canonical text. If a reference is a child of a note element then it will not be canonical, but if it has no specific parent then it will be canonical. Is that correct?</div><div><br></div><div>Martin</div></div></div></div>
_______________________________________________<br>jsword-devel mailing list<br><a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br><a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div><br></div>