<div dir="ltr">Hi DM,<div><br></div><div>How are you getting on with the fix?</div><div><br></div><div>Cheers</div><div>Martin</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 22 September 2015 at 07:50, Peter von Kaehne <span dir="ltr"><<a href="mailto:refdoc@gmx.net" target="_blank">refdoc@gmx.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">To add to that there is of course the time honoured way of avoiding clobbering by adding a counter to a file name when things preexist. Maybe the installer could be made to add clobber preventing counters to Abbreviation and the user can then improve upon that. If they want to.<br>
<span class="HOEnZb"><font color="#888888"><br>
Peter<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
Sent from my phone. Apologies for brevity and typos.On 22 Sep 2015 01:26, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br>
><br>
> Peter,<br>
> You are spot-on.<br>
><br>
> I’d add, that for people that use an English Bible (e.g. KJV, ESV, WEB, NET, ...) in parallel to their local language, it is important that there isn’t an app clumsiness handling a clash.<br>
><br>
> Note: The Thai KJV module in eBible repo now has an Abbreviation of ThaKJV.<br>
><br>
> I was trying to make a change in the shared code (JSword) that would just work in the frontends (e.g. AndBible, BibleDesktop, STEP, …) without change. It was naive.<br>
><br>
> DM<br>
><br>
> > On Sep 21, 2015, at 6:36 PM, Peter von Kaehne <<a href="mailto:refdoc@gmx.net">refdoc@gmx.net</a>> wrote:<br>
> ><br>
> > Hi Martin,<br>
> ><br>
> > Just to be clear:<br>
> ><br>
> > The ModuleName remains the unique identifier for each module. We have<br>
> > introduced some changes how they are constructed for eBible to avoid an<br>
> > ever lengthening number of clashes of duplicates. eBible has a lot of<br>
> > texts we have too - and then it has 100s more. We are interested in teh<br>
> > 100s more, while we wanted to avoid too much grief from the duplicates.<br>
> ><br>
> > Hence the addition of a repo-identifier to the Modulename - which now<br>
> > becomes even more meaningless to users.<br>
> ><br>
> > So this is where Abbreviation comes in. But - Abbreviation does not<br>
> > need to be unique across all offered 1000s of bibles - just unique<br>
> > within a single user install. Thais call one of their Bibles apparently<br>
> > KJV - presumably because it is translated from that and that should be<br>
> > fine as long as no other KJV is installed. Then a solution must be<br>
> > found.<br>
> ><br>
> > So, if you want to use Abbreviation you need to ensure<br>
> ><br>
> > a) That ModuleName remains the internally used unique identifier<br>
> > b) that the app offers some option to resolve Abbreviation clashes. The<br>
> > user must be able to determine in the end how he wants his modules<br>
> > called and how he wants conflicts resolved, preferentially without fall<br>
> > back to a visible ModuleName - because they are now unreadable and will<br>
> > appear more or less meaningless to users.<br>
> ><br>
> > This solution has been discussed extensively on sword-devel and this is<br>
> > the best what we came up with.<br>
> ><br>
> > Peter<br>
> ><br>
> > On Mon, 2015-09-21 at 23:11 +0100, Martin Denham wrote:<br>
> >> Thanks for finding the problem. How long do you think before a fix<br>
> >> is available? I could go back to a pre-abbreviation version or<br>
> >> temporarily revert to the build AB was using before which is about 6<br>
> >> months old? Maybe it wasn't such a good time to take a new version<br>
> >> of JSword. AB won't be using the ebible repo immediately.<br>
> >><br>
> >> I don't anticipate big issues if everything was as it was before with<br>
> >> the addition of getAbbreviation() which could be handled in the front<br>
> >> end. Maybe a new method, something like, getDisplayName() which has<br>
> >> a little logic to determine if initials, abbreviation, or description<br>
> >> is best used in the ui, but I haven't thought that through<br>
> >> thoroughly.<br>
> >><br>
> >> There seem to be some fundamental changes in standards adopted by the<br>
> >> ebible repo. I have not worked out the affect of them yet and did<br>
> >> not follow all the discussion, but personally felt that it would have<br>
> >> been simpler if it had adopted standards that were more similar to<br>
> >> other repos. However, I don't think it will be too difficult to make<br>
> >> the ebible repo available via AB.<br>
> >><br>
> >> Cheers<br>
> >> Martin<br>
> >><br>
> >><br>
> >> On 19 September 2015 at 21:16, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>><br>
> >> wrote:<br>
> >>> I had made getInitials return the abbreviation if there was one.<br>
> >>> And I had added getInternalName to return what getInitials used to<br>
> >>> be. I did this in BookMetaData but didn’t do something comparable<br>
> >>> in Book.<br>
> >>><br>
> >>> It was bad to have changed the contract of getInitials. So I’m<br>
> >>> reverting that change. I’m adding getAbbreviation which will return<br>
> >>> the abbreviation if any and the initials otherwise. Hopefully, no<br>
> >>> one has used getInternalName yet. I’d rather drop it than deprecate<br>
> >>> it.<br>
> >>><br>
> >>> I was trying to make it such that front-ends didn’t need to change<br>
> >>> to support Abbreviations.<br>
> >>><br>
> >>> The remaining challenge regards sorting of book lists visible to<br>
> >>> users. They should either be sorted on what the user sees. So far<br>
> >>> they have either seen Initials or Descriptions. But now it should<br>
> >>> be Abbreviations or Descriptions.<br>
> >>><br>
> >>> The other problem is that in the eBible repository has defined<br>
> >>> uniqueness of abbreviations to be within a language. The assumption<br>
> >>> is that a user will not install books in different languages. But<br>
> >>> we have to have a deterministic sort order.<br>
> >>><br>
> >>> The other problem regards lookup. Adding Abbreviation into the<br>
> >>> search is a complication.<br>
> >>><br>
> >>> — DM<br>
> >>><br>
> >>>> On Sep 19, 2015, at 1:50 PM, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>><br>
> >>>> wrote:<br>
> >>>><br>
> >>>> It’s due to adding support for Abbreviation. There’s a bug in<br>
> >>>> computing the zip file name.<br>
> >>>><br>
> >>>> For example Hindi ERV should try to download HinERV.zip but<br>
> >>>> instead it is HindiERV.zip.<br>
> >>>><br>
> >>>> It has:<br>
> >>>> [HinERV]<br>
> >>>> Abbreviation=HindiERV<br>
> >>>><br>
> >>>> Working on a fix.<br>
> >>>><br>
> >>>> In Him,<br>
> >>>> DM<br>
> >>>><br>
> >>>>> On Sep 18, 2015, at 1:44 PM, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>><br>
> >>>>> wrote:<br>
> >>>>><br>
> >>>>> I'll look this weekend to see what I can find.<br>
> >>>>><br>
> >>>>> Cent from my fone so theer mite be tipos. ;)<br>
> >>>>><br>
> >>>>> On Sep 17, 2015, at 5:43 PM, Martin Denham <<a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>><br>
> >>>>> wrote:<br>
> >>>>><br>
> >>>>>> I think this problem and other related problems in And Bible<br>
> >>>>>> might be related to the new version of JSword because I am<br>
> >>>>>> also having problems with certain books from other repos.<br>
> >>>>>><br>
> >>>>>> Since upgrading to the latest version of JSword I am seeing<br>
> >>>>>> unzip problems with certain files e.g. HindiERV, СПВП, and<br>
> >>>>>> many from eBible.<br>
> >>>>>><br>
> >>>>>> Also, one user has found that foreign characters in the conf<br>
> >>>>>> Description field prevent previously installed modules<br>
> >>>>>> loading. Coincidentally all the above modules have foreign<br>
> >>>>>> characters in their description field. Does anybody recall a<br>
> >>>>>> change in this area during the last 6 months, which was the<br>
> >>>>>> time since my last build of jsword?<br>
> >>>>>><br>
> >>>>>> The error I get when attempting to install a zip is:<br>
> >>>>>><br>
> >>>>>> Not a zip archive<br>
> >>>>>> java.util.zip.ZipException: Not a zip archive<br>
> >>>>>> at java.util.zip.ZipFile.readCentralDir(ZipFile.java:385)<br>
> >>>>>> at java.util.zip.ZipFile.<init>(ZipFile.java:163)<br>
> >>>>>> at java.util.zip.ZipFile.<init>(ZipFile.java:119)<br>
> >>>>>> at org.crosswire.common.util.IOUtil.unpackZip(IOUtil.java:86)<br>
> >>>>>> at<br>
> >>>>>> org.crosswire.jsword.book.install.sword.AbstractSwordInstalle<br>
> >>>>>> r.install(AbstractSwordInstaller.java:241)<br>
> >>>>>> at<br>
> >>>>>> net.bible.service.download.DownloadManager$1.run(DownloadMana<br>
> >>>>>> ger.java:135)<br>
> >>>>>><br>
> >>>>>> I need to do more investigation but wondered if anybody had<br>
> >>>>>> any ideas regarding this problem.<br>
> >>>>>><br>
> >>>>>> Can the above modules be installed without problems in<br>
> >>>>>> BibleDesktop?<br>
> >>>>>><br>
> >>>>>> Thanks<br>
> >>>>>> Martin<br>
> >>>>>><br>
> >>>>>> On 16 September 2015 at 13:26, DM Smith <<br>
> >>>>>> <a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br>
> >>>>>>> I haven’t gotten to it. Other than a file here or there.<br>
> >>>>>>> And mods.d.tar.gz. I’ve been frustrated by how much churn<br>
> >>>>>>> it has had. And that nearly every module had some kind of<br>
> >>>>>>> problem. I hope to look at the zip problem this weekend.<br>
> >>>>>>><br>
> >>>>>>> I was going to work it into the release of BibleDesktop<br>
> >>>>>>> (very soon). But now am thinking a follow-on release.<br>
> >>>>>>><br>
> >>>>>>> — DM<br>
> >>>>>>><br>
> >>>>>>>> On Sep 16, 2015, at 8:21 AM, Martin Denham <<br>
> >>>>>>> <a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>> wrote:<br>
> >>>>>>>><br>
> >>>>>>>> Has anybody else been testing the new eBible repo with<br>
> >>>>>>> the JSword library? I have had and am having various<br>
> >>>>>>> problems.<br>
> >>>>>>>><br>
> >>>>>>>> Martin<br>
> >>>>>>>> _______________________________________________<br>
> >>>>>>>> jsword-devel mailing list<br>
> >>>>>>>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>>>>>>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>>>>>><br>
> >>>>>>><br>
> >>>>>>> _______________________________________________<br>
> >>>>>>> jsword-devel mailing list<br>
> >>>>>>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>>>>>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>>>>>><br>
> >>>>>> _______________________________________________<br>
> >>>>>> jsword-devel mailing list<br>
> >>>>>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>>>>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>>>> _______________________________________________<br>
> >>>>> jsword-devel mailing list<br>
> >>>>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>>>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>>> _______________________________________________<br>
> >>>> jsword-devel mailing list<br>
> >>>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>><br>
> >>> _______________________________________________<br>
> >>> jsword-devel mailing list<br>
> >>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> >>><br>
> >> _______________________________________________<br>
> >> jsword-devel mailing list<br>
> >> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> >> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > jsword-devel mailing list<br>
> > <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> > <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
><br>
> _______________________________________________<br>
> jsword-devel mailing list<br>
> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</div></div></blockquote></div><br></div>