<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Go for it. I'll work the PRs tomorrow. <br><br>Cent from my fone so theer mite be tipos. ;)</div><div><br>On May 31, 2014, at 12:55 PM, Martin Denham <<a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">I needed to do a patch release because I was getting complaints so I simply changed the sort order in my local copy of JSword.<div><br></div><div>Do you mind if I make a JSword pull request that simply changes the sort order to initials and you can add the compare function support later, at your convenience.</div>
<div><br></div><div>Martin</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 24 May 2014 13:38, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>I made the change. I'll respond shortly. We can do both. There's a compare function that can be passed. <br>
<br>Cent from my fone so theer mite be tipos. ;)</div><div><div class="h5"><div><br>On May 24, 2014, at 7:09 AM, Martin Denham <<a href="mailto:mjdenham@gmail.com" target="_blank">mjdenham@gmail.com</a>> wrote:<br><br>
</div><blockquote type="cite"><div><div dir="ltr">The change to name order occurred 4 months ago with 'Optimized Books, especially for lookups' but I can't see any specific reason for the change in order unless I am missing something. I originally added order by initials 11 months ago while solving problems with books having the same description. Here is the change 4 months ago which changed sort back to name:<div>
<br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>Optimized Books, especially for lookups.</div></div><div><div>Use books directly rather than calling getBooks, which creates a copy.</div>
</div>
<div><div>No longer use BookSet internally, but TreeSet instead.</div></div><div><div>Lookup now uses hash maps for O(1) for initials and name. Still loops for case insensitive, but only once.</div></div><div><div>Removed getWriteableDrivers. Deprecated unregisterDriver and getMaxLength.</div>
</div><div><div>BookFilterIterator now takes an Iterable<Book> rather than a List<Book>.</div></div><div><div><b>AbstractBookMetaData now sorts name before initials.</b></div></div></blockquote><br><div>If there are no objections I would like to raise an issue and implement the change to sort by initials.</div>
<div><br></div><div>Martin</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 22 May 2014 22:26, Martin Denham <span dir="ltr"><<a href="mailto:mjdenham@gmail.com" target="_blank">mjdenham@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The books are now being sorted by <a href="http://book.name" target="_blank">book.name</a> which is not the name seen on <a href="http://www.crosswire.org/sword/modules/ModDisp.jsp?modType=Bibles" target="_blank">this screen</a> but is the description. So JSword is sorting books by description.<div>
<br></div><div>JSword used to sort by book.initials (which confusingly is name on <a href="http://www.crosswire.org/sword/modules/ModDisp.jsp?modType=Bibles" target="_blank">this screen</a>) until a few weeks ago. However, there were various changes made including the different sort order.</div>
<div><br></div><div>Since description is random descriptive text but name encapsulates key text which groups similar books together, could we agree to switch back to sorting by initials?</div><div><br></div><div>I have a user who is quite upset over this issue and claims the order is "complete chaos". I could do the sorting in And Bible but I get the book list very frequently and it would have a small affect on performance.</div>
<span><font color="#888888">
<div><br></div><div>Martin</div></font></span></div>
</blockquote></div><br></div>
</div></blockquote></div></div><div class=""><blockquote type="cite"><div><span>_______________________________________________</span><br><span>jsword-devel mailing list</span><br><span><a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a></span><br>
<span><a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a></span><br></div></blockquote></div></div><br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>jsword-devel mailing list</span><br><span><a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a></span><br><span><a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a></span><br></div></blockquote></body></html>