<div dir="ltr">The Vulgate properties files are also missing mappings for the book of Esther.<div><br></div><div>None of the chapters match but I think some mappings should be possible. Comparing visually it seems like Vulgate chapter 3 starts similarly to KJV chapter 1.</div>
<div><br></div><div>Martin</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 2 April 2014 17:52, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I think I've found some errors in the o.c.j.versification.Vulg.properties file.<div>
<br></div><div>I'm ignoring the verse 0 mapping bug in the following discussion.<br><div><br><div>I'd like verification. I'm attaching the modified file.</div><div><br></div><div>I went through the file entry by entry, comparing CPDV to the KJV modules. The advantage of CPDV is that it is English and I can readily validate the versification. I'm making the assumption the CPDV is representative of the Vulgate v11n.</div>
</div><div><br></div><div>Psalm 2</div><div>There are no mappings. But it appears that</div><div><span style="white-space:pre-wrap"> </span>Vulg.Ps 2:12-13 = KJV.Ps.2.12</div><div>Without this mapping I'm getting an NPE. Apparently the default mapping of Vulg.Ps.2.13 = KJV.Ps.2.13 is causing this.</div>
<div><br></div><div>Psalm 3</div><div>Vulg.Ps.3.9 is not present in the KJV. I think this should be:</div><div>Ps.3.9=?Missing</div><div>When I have this, I'm getting errors that prevent the chapter from showing.</div>
<div>Having:</div><div>Ps.3.9=Ps.3.8</div><div>works (mapping both Vulg 3.8 and 3.9 to KJV 3.8) but I don't think this is right.</div><div><br></div><div>Psalm 4</div><div>This has a canonical title in the KJV, but there is no mapping for this. I think the following should be added:</div>
<div><div style="margin:0px;font-size:11px;font-family:Monaco">Ps.4.1-Ps.4.8=Ps.4.0-Ps.4.7</div></div><div style="margin:0px;font-size:11px;font-family:Monaco">With this the verses line up as in others that have a canonical title.</div>
<div><br></div><div>Psalm 28</div><div>This has the following mapping:</div><div>Ps.28.1=Ps.29.0-Ps.29.0</div><div>This is preventing KJV verse 1 from showing. Obviously the second .0 should be .1</div><div><div>Ps.28.1=Ps.29.0-Ps.29.1</div>
</div><div><br></div><div>Psalm 98</div><div>This maps to KJV.Ps.99 but there is no mapping in the file. The impact is that it uses the default mapping to KJV.Ps.98.</div><div>This should be:</div><div><div style="margin:0px;font-size:11px;font-family:Monaco">
Ps.98.1=Ps.99.0-Ps.99.1</div><div style="margin:0px;font-size:11px;font-family:Monaco">Ps.98.2-Ps.98.9=Ps.99.2-Ps.99.9</div></div><div><br></div><div>Psalm 99</div><div>This is rather complex. The Vulgate verse 1 is the KJV canonical title which is pre-verse in verse 1. Vulgate verse 2 is KJV verse 1 *and* verse 2. </div>
<div>However it is mapped as:</div><div><div style="margin:0px;font-size:11px;font-family:Monaco">Ps.99.1=Ps.100.0-Ps.100.1</div><div style="margin:0px;font-size:11px;font-family:Monaco">Ps.99.2-Ps.99.5=Ps.100.2-Ps.100.5</div>
</div><div>Which treats Vulgate verse 1 as the merge of KJV's canonical title and verse content.</div><div>This should be something like:</div><div><div style="margin:0px;font-size:11px;font-family:Monaco"><div style="margin:0px">
Ps.99.1=Ps.100.0</div><div style="margin:0px">Ps.99.2=Ps.100.1</div><div style="margin:0px">Ps.99.2-Ps.99.5=Ps.100.1-Ps.100.5</div><div><br></div><div>Psalm 108</div><div>This is just like Psalm 99.</div><div>However it is mapped as:</div>
<div><div style="margin:0px">Ps.108.1=Ps.109.0-Ps.109.1</div><div style="margin:0px">Ps.108.2-Ps.108.31=Ps.109.2-Ps.109.31</div></div><div>It should be something like:</div><div><div style="margin:0px">Ps.108.1=Ps.109.0</div>
<div style="margin:0px">Ps.108.2=Ps.109.1</div><div style="margin:0px">Ps.108.2-Ps.108.31=Ps.109.2-Ps.109.31</div></div><div><br></div><div>Song of Solomon 5-7</div><div>This is complex. The Vulgate and KJV have different chapter boundaries.</div>
<div>The last verse of Vulgate.Song.5 is the first verse of KJV.Song.6. This is correctly represented.</div><div>The last verse of KJV.Song.6 is split between the last verse of Vulgate.Song.6 and the first verse of Song.7.</div>
<div>Then Vulgate verse 2-ff should map to KJV verse 1-ff.</div><div>Additionally, KJV verse 12 is not part of the Vulgate.</div><div>It is correct that verse 13 is an identity mapping.</div><div>The mapping has:</div><div>
Song.7.1=Song.6.13!b</div><div>Song.7.1=Song.7.1</div><div>This incorrectly maps KVJ verse 1 to Vulgate verse 1.</div><div>This should be:</div><div><div style="margin:0px">Song.7.1=Song.6.13!b</div><div style="margin:0px">
Song.7.2-Song.7.12=Song.7.1-Song.7.11</div></div><div style="margin:0px">There is a problem with KJV.Song.7.12 It doesn't show with KJV first or second in parallel view w CPVD.</div><div style="margin:0px">There should be an entry like:</div>
<div style="margin:0px">?=Song.7.12</div><div style="margin:0px">But that doesn't make it show up, either.</div><div style="margin:0px"><br></div><div style="margin:0px">Daniel 3</div><div style="margin:0px">Deuterocanonical material is in the middle of the chapter in the Vulgate. Essentially, extra verses are from 3.24-3.90.</div>
<div style="margin:0px">However, there is no mapping for this deuterocanonical range. The impact is that KJV content shows up in parallel view for 3.24-3.90, going through chapter 4 and into chapter 5.</div><div style="margin:0px">
<br></div><div style="margin:0px">There should be an entry like:</div><div style="margin:0px"><div style="margin:0px">Dan.3.24-Dan.3.90=?deuterocanonical</div><div style="margin:0px">But this doesn't work. Causes errors.</div>
<div style="margin:0px"><br></div><div>I don't know if any of this was from changes that I made to the mapping code. (Such as having ? on either side of =.)</div><div><br></div><div style="margin:0px">Some of the things I have learned from this exercise:</div>
<div style="margin:0px">o It is really easy to make mistakes.</div><div style="margin:0px">o If identity mapping is not true, there needs to be a mapping for every verse in both v11ns. If the chapters don't have the same number of verses then merge, split or missing has to be in the file.</div>
</div><div><br></div><div>In view of the last one, I think a good test is to check the mapping to ensure that every verse in a v11n is covered by the mapping both forward and back. That is if a verse is mapped, then both from and to should be valid. If a verse from the v11n is not in the map then the identity must exist in the other v11n.</div>
<div><br></div><div>Comment on the verse 0 bug. Currently the mapping files use verse 0 to represent the pre-verse content of verse 1. This hides the SWORD/JSword meaning that verse 0 means book introduction (with chapter 0) or chapter introduction. The simple fix is to add an explicit verse 0 mapping. The better solution, that we've agreed on, is to change the mapping to use Book.n.1!pv instead of Book.n.0 to reference the preverse and Book.n.1!v to represent verse content. Then 0 means 0.</div>
<div><br></div><div>In Him,</div><div><span style="white-space:pre-wrap"> </span>DM</div><div><br></div><div></div></div></div></div></div><br><div style="word-wrap:break-word"><div><div><div style="margin:0px;font-size:11px;font-family:Monaco">
<div></div></div></div></div></div><br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div><br></div>