<div dir="ltr">Thanks DM,<div><br></div><div>There are a lot of improvements and fixes going into JSword. Tell me when you are happy and I will pull the updates for testing and use in a future release of And Bible.</div><div>
<br></div><div>Martin</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 6 March 2014 01:23, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><br><div><div>On Mar 5, 2014, at 5:44 PM, Martin Denham <<a href="mailto:mjdenham@gmail.com" target="_blank">mjdenham@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr"><div>Are there any important fixes that have been made to JSword during the last few weeks?<br></div><div><br></div>I am planning a patch release to And Bible to fix a few small errors. I don't plan to include all recent JSword updates in this patch release because some of the changes are fairly significant changes.<div>
<br><div>My last pull was:</div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div>DM Smith <<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>> on 03/02/14 04:33</div>
<div>030d4c1b512296d6c89f7066dc5246d03159fa83 </div>
<div>Fixed a null pointer error in LuceneIndex close.</div><div>Used IOUtil to close closable resources.</div></blockquote></div></div></blockquote><br></div></div></div><div>I won't go over them piece by piece but at major points you might want to consider:</div>
<div>The changes upto the following are just cleanup and shouldn't have any impact on your code:</div><div><span style="font-size:13px">07cd243 on </span><span style="font-size:13px">February 10, 2014 at 2:26:18 PM EST</span></div>
<span style="font-size:13px">Cleanup of Versification Mapper classes.</span><br style="font-size:13px"><span style="font-size:13px">Added missing license</span><br style="font-size:13px"><span style="font-size:13px">put private variables at bottom of class</span><br style="font-size:13px">
<span style="font-size:13px">Added/cleaned up JavaDoc</span><br style="font-size:13px"><span style="font-size:13px">Removed unneeded casts.</span><br style="font-size:13px"><span style="font-size:13px">Cleaned up CheckStyle complaints.</span><div>
<span style="font-size:13px"><br></span></div><div><span style="font-size:13px">After that commit, the goal was to move to VerseRange and a fast parser for Chris' mapping code. This was a performance optimization.</span></div>
<div><span style="font-size:13px">This was done in stages.</span></div><div><span style="font-size:13px">The next commit to consider is:</span></div><div><span style="font-size:13px">0f3fbc6 on </span><span style="font-size:13px">February 13, 2014 at 10:56:08 PM EST</span></div>
<div><span style="font-size:13px">Merge branch 'osisify'</span></div><div><span style="font-size:13px">These changes should just make your code faster and not change how it works.</span></div><div><span style="font-size:13px"><br>
</span></div><div><span style="font-size:13px">Then:</span></div><div><span style="font-size:13px">5052d1d on </span><span style="font-size:13px">March 1, 2014 at 3:15:39 PM EST</span></div><div><span style="font-size:13px">Which brings together all the parts of making mapping faster.</span></div>
<div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">This includes the addition of BZip2, Gzip and XZ, but this code won't be exercised for a while. But the same commit (</span><span style="font-size:13px">4f77188) also changes the 3rd-party jars in the POM. At this point, other than Apache Commons Compress, you can stay with the old jars. No changes were made due to these upgrades.</span></div>
<div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Beyond this point is a bit risky. I'm seeing problems with the change to WebResource at </span><span style="font-size:13px">9a03a34 </span><span style="font-size:13px">(staying with the prior code is safe, but the new code is preventing downloads.)</span></div>
<div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">After this WebResource commit, there are some fixes you may want to cherry pick:</span></div><div><span style="font-size:13px">4da9a83 on </span><span style="font-size:13px">March 1, 2014 at 10:32:34 PM EST -- Fixes the Verse.toString() NPE</span></div>
<div><span style="font-size:13px">90297ec on </span><span style="font-size:13px">March 2, 2014 at 1:00:14 PM EST -- Fixes an NPE when changing from KJV v11n to another v11n when verse 0 is included in the range to display.</span></div>
<div><span style="font-size:13px">55bb7be on </span><span style="font-size:13px">March 2, 2014 at 10:11:29 PM EST -- Fixes a bug that said the NT started w/ Genesis.</span></div><div><span style="font-size:13px">96ba5d8 on </span><span style="font-size:13px">March 2, 2014 at 10:21:40 PM EST -- Changes the Polish language name to Polski.</span></div>
<div><span style="font-size:13px">f9d0237 on </span><span style="font-size:13px">March 3, 2014 at 9:16:40 PM EST -- Improves the bad xref warning to not include stack trace.</span></div><div><span style="font-size:13px"><br>
</span></div><div><span style="font-size:13px">Obviously, you'll want all the fixes you've supplied.</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">I'm working on fixing the delete of a book immediately after downloading it. But I have to fix or revert the WebResource code first.</span></div>
<div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Hope this helps,</span></div><div><span style="font-size:13px"><span style="white-space:pre-wrap"> </span>DM</span></div></div><br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div><br></div>