<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">If you make the pull request, I have the time to apply it. Or I can make the change.<div><br></div><div>-- DM</div><div><br><div><div>On Feb 8, 2014, at 9:08 AM, Martin Denham <<a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">You would only notice it on very low memory devices - it is not a memory leak, just an extra memory requirement. Switching all RocketPassage references to the default passage type, which for me is RangedPassage seems to have worked. I will check it in later.<div>
<br></div><div>Thanks</div><div>Martin</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 6 February 2014 23:26, Chris Burrell <span dir="ltr"><<a href="mailto:chris@burrell.me.uk" target="_blank">chris@burrell.me.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">No reason. This could be changed to use the factory or some lighter implementation. </p><p dir="ltr">Haven't seen the oom myself and Ben running it for 9 months now. But doesn't mean it doesn't exist</p><p dir="ltr">Chris</p>
<div class="gmail_quote"><div>On 6 Feb 2014 22:36, "Martin Denham" <<a href="mailto:mjdenham@gmail.com" target="_blank">mjdenham@gmail.com</a>> wrote:<br type="attribution"></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr">When I switched to using RangedPassage instead of RocketPassage by default it improved memory usage but there are 8 specific uses of RocketPassage in VersificationToKJVMapper.<div>E.g.</div><div>303: matchingVerses = new RocketPassage(this.nonKjv);</div>
<div>409: newKey = new RocketPassage(versification);</div><div>503: return new QualifiedKey(new RocketPassage(target));</div><div>Etc.</div><div><div><br></div><div>Is there any reason why any of the 8 specific references to RocketPassage in VersificationToKJVMapper should not use the default passage class returned by PassageKeyFactory.createEmptyKeyList()? I could imagine that if any of the Passages would be likely to contain a large number of verses then a RocketPassage would be better, but I don't think any will. However, I don't have enough familiarity with the code to be sure.</div>
</div><div><br></div><div>I am actually getting an OutOfMemoryError occasionally when testing on a virtual device caused by the occurrence on line 303 and possibly elsewhere.</div><div><br></div><div>Martin</div></div>
<br></div>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div>
<br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div><br></div></div>
_______________________________________________<br>jsword-devel mailing list<br><a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>http://www.crosswire.org/mailman/listinfo/jsword-devel<br></blockquote></div><br></div></body></html>