<p dir="ltr">No reason. This could be changed to use the factory or some lighter implementation. </p>
<p dir="ltr">Haven't seen the oom myself and Ben running it for 9 months now. But doesn't mean it doesn't exist</p>
<p dir="ltr">Chris</p>
<div class="gmail_quote">On 6 Feb 2014 22:36, "Martin Denham" <<a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">When I switched to using RangedPassage instead of RocketPassage by default it improved memory usage but there are 8 specific uses of RocketPassage in VersificationToKJVMapper.<div>E.g.</div><div>303: matchingVerses = new RocketPassage(this.nonKjv);</div>
<div>409: newKey = new RocketPassage(versification);</div><div>503: return new QualifiedKey(new RocketPassage(target));</div><div>Etc.</div><div><div><br></div><div>Is there any reason why any of the 8 specific references to RocketPassage in VersificationToKJVMapper should not use the default passage class returned by PassageKeyFactory.createEmptyKeyList()? I could imagine that if any of the Passages would be likely to contain a large number of verses then a RocketPassage would be better, but I don't think any will. However, I don't have enough familiarity with the code to be sure.</div>
</div><div><br></div><div>I am actually getting an OutOfMemoryError occasionally when testing on a virtual device caused by the occurrence on line 303 and possibly elsewhere.</div><div><br></div><div>Martin</div></div>
<br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div>