<p dir="ltr">I'd agree with your latest</p>
<div class="gmail_quote">On 31 May 2013 16:43, "Martin Denham (JIRA)" <<a href="mailto:jira@crosswire.org">jira@crosswire.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<table align="center" border="0" cellpadding="0" cellspacing="0" style="width:100%;background-color:#f0f0f0">
<tr valign="top">
<td style="padding:16px!important">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="width:100%;background-color:#ffffff;border:1px solid #bbbbbb">
<tr valign="top">
<td bgcolor="#4d5c47" style="background-color:#4d5c47;color:#ffffcc;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1"><img src="http://www.crosswire.org/bugs/s/en_US-l73y3/783/14/_/jira-logo-scaled.png" alt="" style="vertical-align:top"></td>
</tr><tr valign="top">
<td style="padding:32px 32px 0 32px">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0">
<img src="http://www.crosswire.org/bugs/secure/useravatar?avatarId=10062" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin:0 16px 16px 0">
<div style="padding:0 0 8px 0;font-size:12px;line-height:18px">
<a rel="mjdenham" href="http://www.crosswire.org/bugs/secure/ViewProfile.jspa?name=mjdenham" style="color:#000000" target="_blank">Martin Denham</a>
commented on <img src="http://www.crosswire.org/bugs/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style="color:#000000;text-decoration:none" href="http://www.crosswire.org/bugs/browse/JS-273" target="_blank">JS-273</a>
</div>
<div style="font-size:16px;line-height:20px;padding:2px 0 16px 0">
<a style="color:#000000;text-decoration:none" href="http://www.crosswire.org/bugs/browse/JS-273" target="_blank"><strong>Is 53 not found in ESV</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td style="padding:0 32px 32px 32px">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%" width="100%">
<tr valign="top">
<td style="width:64px;white-space:nowrap"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="width:100%;font-size:12px;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0 0 16px 0">
<div style="background-color:#edf5ff;padding:12px;border:1px solid #dddddd"><p>So the current implementation of contains(key) is containsAllOf(key) but in this particular instance we are expecting containsAnyOf(key). Is that right?</p>
<p>If so then we could either consider i) changing contains to be containsAnyOf or ii) adding a different function containsAnyOf or iii) changing contains to be containsAnyOf when the key is a chapter.</p>
<p>From an And Bible perspective book.contains(key) is used to work out if there is anything that can be shown on the screen so contains(key) is always used in the sense of containsAnyOf so my initial preference would be to change the implementation of book.contains() to be containsAnyOf but there may be use cases others would raise that I haven't thought of.</p>
<p>----------<br>
I just remembered I emailed JSword-devel regarding a different issue related to VerseRange.contains() on 4th May so maybe contains() needs consideration in general. I need to raise a Jira for that because I don't think one was raised and I don't believe it has been fixed (I worked around it in AB). I'll raise a jira but hopefully nobody gets confused between the two different contains() problems.<br>
----------</p>
<p>Martin</p></div>
<div style="color:#505050;padding:4px 0 0 0"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding:0 16px 16px 16px;text-align:center">
This message is automatically generated by JIRA.<br>
If you think it was sent incorrectly, please contact your JIRA administrators<br>
For more information on JIRA, see: <a style="color:#000000" href="http://www.atlassian.com/software/jira" target="_blank">http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table>
</div>
<br>_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br></blockquote></div>