<div dir="ltr">Hi DM<div><br></div><div style>I've updated against the latest version, but JSword still seems to be outputting xgen titles with the verse 0 inside. For example, for Exo 3:5-5:12</div><div style><br></div>
<div style>I get the following titles in the OSIS:</div><div style><title type="x-gen">Exodus 3:5-22</title><br></div><div style><title type="x-gen">Exodus 4</title><br></div><div style>
<title type="x-gen">Exodus 5:0-12</title><br></div><div style><br></div><div style>Can you point me to where you made a change around this? Also, any chance you can point me to the commit/patch for simple.xsl. I'll have to integrate that to STEP as well.</div>
<div style><br></div><div style>Chris</div><div style><br></div><div style><br></div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 28 February 2013 13:57, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The OSIS module builder, osis2mod, creates markup for material that stands before the verse number. JSword needed to be changed to handle this.<br>
<br>
FYI, a module does not have the <verse> tag in it. It is the responsibility of the engine (SWORD/JSword) to support the frontend in putting in that number. SWORD and JSword handle it differently. In JSword, we put back in the verse number. In SWORD, they split the content into two parts that can be retrieved independently.<br>
<br>
I changed how JSword figures out where to put the verse tag.<br>
<br>
In the past, JSword merely wrapped the content from the module (having been converted to OSIS) with a verse element. Then the xslt when handling the verse element, pulled titles and put them before the verse.<br>
<br>
Now, JSword iterates through the OSIS content looking for the best place to split the content. Basically, it looks for the last element to have subType="x-preverse" to be the split.<br>
<br>
In looking at this, I examined all Bible modules in all repositories and looked at Psalm 3:0-2 for misplaced verse markers. The reason for this is that Psalm titles are canonical and are not marked up well in modules. The reason to include 0 and 2 is that some modules put the title in verse 0. Others have the title as verse 1.<br>
<br>
I found that titles marked type="psalm" may not have been marked subType="x-preverse" and canonical="true". I adjusted the code to update these if there were not conflict.<br>
<br>
The upshot of this is that the xslt can now be simpler. It can handle the title directly, not within the verse container.<br>
<br>
Doing that fixes an existing bug in the stylesheet. It would not show titles in verse 0 if they were marked x-preverse. There were a lot of these.<br>
<br>
So you may want to grab a new copy of simple.xsl from Bible Desktop. It has a number of other improvements as well.<br>
<br>
In Him,<br>
DM<br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</blockquote></div><br></div>