<div dir="ltr">In terms of committing - everything should work with the dependencies as they are, so no need to wait on me on that. We can fine-tune which dependencies get pulled later. A front-end can always exclude this for now if they desire</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On 25 February 2013 20:49, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
OK, it's all there. We need to merge this in fairly quickly as it prevents lots of other development/fixes.<br>
<br>
The changes were fairly simple. Basically a few global search and replace operations:<br>
Replace<br>
import org.crosswire.common.util.Logger;<br>
with:<br>
import org.slf4j.Logger;<br>
import org.slf4j.LoggerFactory;<br>
<br>
Replace<br>
Logger.getLogger<br>
with<br>
LoggerFactory.getLogger<br>
.<br>
<br>
Replace<br>
log.fatal<br>
with<br>
log.error.<br>
<br>
I've marked the old implementation, which is no longer used by JSword, as deprecated. If you are using it, this will help you find where to change your code as described above.<br>
<br>
To change to using formats, looked for every log statement that had + (concatenation) of strings.<br>
Used {} as a placeholder for what was concatenated and put the arguments at the end.<br>
Note: the last argument can be an exception that doesn't pair with a {}. It will then produce a stack trace.<br>
<br>
I also changed ivy.xml to bring in the library, to bring in a plugin for writing to Java Logging and another to redirect apache commons logging to SLF4J. If you use ant to build and you don't want to use Java logging, please change your local copy to bring in the plugin you want.<br>
<br>
Working together in His Service,<br>
DM<br>
<div class="HOEnZb"><div class="h5"><br>
On Feb 25, 2013, at 9:51 AM, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br>
<br>
> I'm working to use slf4j.<br>
><br>
> It will be a series of commits.<br>
> The first is to make o.c.c.util.Logger be a facade for slf4j 1.7.2 and bind to Java Logging. Lots is deprecated as it is not in the slf4j API.<br>
> The second will be to remove the binding to Java Logging and mark o.c.c.util.Logger as deprecated.<br>
> The third will be to replace o.c.c.util.Logger with org.slf4j.Logger and org.slf4j.LoggerFactory.<br>
><br>
> Once this is done, we can look at eliminating concatenation in the calls to logger, using formats instead.<br>
><br>
> I'll put a pull request up shortly for the first.<br>
><br>
> On Feb 12, 2013, at 12:55 PM, Douglas Campos <<a href="mailto:qmx@qmx.me">qmx@qmx.me</a>> wrote:<br>
><br>
>> On Wed, Feb 06, 2013 at 01:46:03PM +0000, Chris Burrell wrote:<br>
>>> Hi Martin / DM<br>
>>><br>
>>> What about looking at replacing the JSword logging framework with SLF4j.<br>
>>> For android, all you'd do is include the Android bindings:<br>
>>> <a href="http://www.slf4j.org/android/" target="_blank">http://www.slf4j.org/android/</a><br>
>> +9001 for using slf4j - it's one of the best logging façades out there :)<br>
>><br>
>> --<br>
>> qmx<br>
>><br>
>> _______________________________________________<br>
>> jsword-devel mailing list<br>
>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
><br>
><br>
> _______________________________________________<br>
> jsword-devel mailing list<br>
> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br>
<br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</div></div></blockquote></div><br></div>