<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I've just updated the pull request on github for proper handling of verse 0. All tests pass, I've also re-enabled a bunch that were commented out.<div><br></div><div>Chris, I removed the verse 0 skipping that you added to BitwisePassage's iterator. I added some is*Intro methods to Versification so that you can apply the logic in the front-end (or closer to it.)</div><div><br></div><div>The biggest change is that verse 0 does not show up much anymore when converting a range to a string.</div><div><br></div><div>I think this pull request is ready.</div><div><br></div><div>There may be more to do as a result of further testing or in real-world usage in a front-end, but I think the av11n work is done with this. </div><div><br></div><div>In His Service,</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>DM</div><div><br><div><div>On Feb 17, 2013, at 3:12 AM, Chris Burrell <<a href="mailto:chris@burrell.me.uk">chris@burrell.me.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p dir="ltr">Thanks for letting me know about verse 0 changes. I'll wait till you're done because step has special logic to work out whether something is the beginning of a chapter</p>
<div class="gmail_quote">On 17 Feb 2013 05:22, "DM Smith" <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Lots of changes to 35 files (including tests) in support of Alternate Versification.<br>
You can see it, play with it and comment on it at:<br>
<a href="https://github.com/crosswire/jsword/pull/35/files" target="_blank">https://github.com/crosswire/jsword/pull/35/files</a><br>
<br>
I've tried to make verse 0 not show up quite as much. So Chapter 0 and 1 are both considered as the start of a book. Likewise, verse 0 and 1 are the start of a chapter.<br>
<br>
This has an annoying side-effect. Two verse ranges may have the same "name" but be different internally. That is Gen 0:0-50:26, Gen 1:0-50:26 and Gen 1:1-50:26 are different but all have the name "Gen"<br>
<br>
Will work on that tomorrow.<br>
<br>
Together in His Service,<br>
DM<br>
<br>
On Feb 16, 2013, at 1:46 PM, DM Smith <<a href="mailto:dmsmith@crosswire.org">dmsmith@crosswire.org</a>> wrote:<br>
<br>
> I'm going to have to change Verse to take a versification. Was hoping not to do that.<br>
><br>
> The fundamental reason is that we have too much code that allows for Verse to be in a container that requires Verse to be Comparable.<br>
><br>
> I could do a brain dead ordering of book, chapter, verse. This works for chapter and verse, but not for book. Books are not ordered alphabetically, but in versification order.<br>
><br>
> Right now, compareTo is deprecated (to see what needs to change), but it also means that I'd have to remove "implements Comparable" as well.<br>
><br>
> Anyway, there's a patch for this in Jira and it passes all tests. Thanks John for the patch.<br>
><br>
> In Him,<br>
> DM<br>
> _______________________________________________<br>
> jsword-devel mailing list<br>
> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br>
<br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</blockquote></div>
_______________________________________________<br>jsword-devel mailing list<br><a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>http://www.crosswire.org/mailman/listinfo/jsword-devel<br></blockquote></div><br></div></body></html>