It's strange that the JS-166 JIRA notification didn't come through via e-mail like new JIRAs normally do.<br><br><div class="gmail_quote">On 2 March 2011 21:18, Martin Denham <span dir="ltr"><<a href="mailto:mjdenham@gmail.com">mjdenham@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div>Thanks for the quick fix. Strong's Number links in the RST work great now. </div><div><br></div><div>I discovered an And Bible bug too in the same area affecting non-OSIS format modules which confused me for a while but now everything is fine.</div>
<div><br></div><font color="#888888"><div>Martin</div></font><div><div></div><div class="h5"><div><br><div class="gmail_quote">On 1 March 2011 13:57, DM Smith <span dir="ltr"><<a href="mailto:dmsmith@crosswire.org" target="_blank">dmsmith@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Martin,<br>
Thanks for the report. I've just checked in a fix for this bug: JS-166. The changed file is o.c.j.book.filter.gbf.GBFTags.java. Can you verify that it fixes your problem.<br>
In Him,<br>
<font color="#888888"> DM<br>
</font><div><div></div><div><br>
On Feb 28, 2011, at 9:20 PM, DM Smith wrote:<br>
<br>
> The problem seems to be the following:<br>
> RST produces:<br>
> <div><br>
> <title type='x-gen'><br>
> Colossians 1:1<br>
> </title><br>
> <verse osisID='Col.1.1'><br>
> <w lemma='strong:3972'><br>
> Павел<br>
> </w><br>
> ,<br>
> <w lemma='strong:1223|strong:2307'><br>
> волею<br>
> </w><br>
><br>
> <w lemma='strong:2316'><br>
> Божиею<br>
> </w><br>
><br>
> <w lemma='strong:652'><br>
> Апостол<br>
> </w><br>
><br>
> <w lemma='strong:2424'><br>
> Иисуса<br>
> </w><br>
><br>
> <w lemma='strong:5547'><br>
> Христа<br>
> </w><br>
> ,<br>
> <w lemma='strong:2532'><br>
> и<br>
> </w><br>
><br>
> <w lemma='strong:5095'><br>
> Тимофей<br>
> </w><br>
> <w lemma='strong:80'><br>
> брат<br>
> </w><br>
> ,<br>
> </verse><br>
> </div><br>
> KVJ produces:<br>
> <div><br>
> <title type='x-gen'><br>
> Colossians 1:1<br>
> </title><br>
> <verse osisID='Col.1.1'><br>
> <w lemma='strong:G3972' morph='robinson:N-NSM' src='1'><br>
> Paul<br>
> </w><br>
> ,<br>
> <w lemma='strong:G652' morph='robinson:N-NSM' src='2'><br>
> an apostle<br>
> </w><br>
><br>
> <w lemma='strong:G2424' morph='robinson:N-GSM' src='3'><br>
> of Jesus<br>
> </w><br>
><br>
> <w lemma='strong:G5547' morph='robinson:N-GSM' src='4'><br>
> Christ<br>
> </w><br>
><br>
> <w lemma='strong:G1223' morph='robinson:PREP' src='5'><br>
> by<br>
> </w><br>
><br>
> <w lemma='strong:G2307' morph='robinson:N-GSN' src='6'><br>
> the will<br>
> </w><br>
><br>
> <w lemma='strong:G2316' morph='robinson:N-GSM' src='7'><br>
> of God<br>
> </w><br>
> ,<br>
> <w lemma='strong:G2532' morph='robinson:CONJ' src='8'><br>
> and<br>
> </w><br>
><br>
> <w lemma='strong:G5095' morph='robinson:N-NSM' src='9'><br>
> Timotheus<br>
> </w><br>
><br>
> <transChange type='added'><br>
> our<br>
> </transChange><br>
><br>
> <w lemma='strong:G3588 strong:G80' morph='robinson:T-NSM robinson:N-NSM' src='10 11'><br>
> brother<br>
> </w><br>
> ,<br>
> </verse><br>
> </div><br>
><br>
> There are 2 significant differences in the RST:<br>
> First is does not prefix the various Strong's Numbers with G or H. Second it separates two numbers in a row with '|' rather than ' '.<br>
><br>
> The first problem has to be fixed in ..../GBFilter.java as there is no way of telling whether a value is Greek (G) or Hebrew (H) otherwise. The numbers overlap. The second can be fixed in either simple.xsl (or whatever you are using), or in GBF Filter. Since OSIS specifies a space, GBFFilter should be changed. Also, it fixes it once for all frontends.<br>
><br>
><br>
> In Him,<br>
> DM<br>
><br>
> On Feb 28, 2011, at 4:03 PM, Martin Denham wrote:<br>
><br>
>> And Bible throws an error when attempting to parse the xml from the Russian RST module. It appears to me that the Strongs tags do not conform to the correct xml format.<br>
>><br>
>> I printed out the OSIS xml for the beginning of Colossians and got (ignore the question marks which are just Russian characters):<br>
>> <verse osisID='Col.1.1'/>?????<WG3972>, ?????<WG1223><WG2307> ??????<WG2316>...<br>
>><br>
>> which isn't valid xml because the Strongs tags are all unmatched opening tags, despite not being valid OSIS tags, but then the RST is originally in GBF format and not OSIS.<br>
>><br>
>> When I select RST in BibleDesktop and turn on Strongs Numbers it displays the numbers but they are not shown as Strongs links but large red tags.<br>
>><br>
>> Any idea what might be the problem here - I thought it could possibly be an error in the module or in JSword GBF conversion to OSIS?<br>
>><br>
>> This error also affects the RusVZh module. Both modules are GBF format.<br>
>><br>
>> Thanks<br>
>> Martin<br>
>> _______________________________________________<br>
>> jsword-devel mailing list<br>
>> <a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br>
>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
><br>
><br>
> _______________________________________________<br>
> jsword-devel mailing list<br>
> <a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
<br>
<br>
_______________________________________________<br>
jsword-devel mailing list<br>
<a href="mailto:jsword-devel@crosswire.org" target="_blank">jsword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br>