Actually, that is exactly what I did. Is it not working for you?<br><br>Don<br><br><div><span class="gmail_quote">On 2/15/06, <b class="gmail_sendername">DM Smith</b> <<a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com
</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">To create your next patch that can be used directly in Eclipse, install
<br>subclipse, the Subversion Eclipse plugin, then right click on the<br>project needing to be patched. Under Team choose Create Patch. This will<br>bring up a wizard. On the first page you will be asked where you want to
<br>save the patch. And on the next, there will be a check box for recursion<br>into sub-directories. Make sure that is checked and then click finish.<br><br>Don Brown wrote:<br>> Ok, I've attached a patch with small cleanups and improvements. Next,
<br>> I'll tackle converting actions to jsword conventions.<br>><br>> Don<br>><br>> On 2/14/06, *Don Brown * <<a href="mailto:donald.brown@gmail.com">donald.brown@gmail.com</a><br>> <mailto:<a href="mailto:donald.brown@gmail.com">
donald.brown@gmail.com</a>>> wrote:<br>><br>> Ok, I'll work on it some more this week. Glad to hear things are<br>> moving along.<br>><br>> Don<br>><br>><br>> On 2/14/06, * DM Smith* <
<a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com</a><br>> <mailto:<a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com</a>>> wrote:<br>><br>> Don,<br>> How are you coming with putting finishing touches on
<br>> Journaling. I'd<br>> like to finish it up and release it. I have some bug fixes<br>> that should<br>> be released. So I am eager to do a release.<br>> In His Service,
<br>> DM<br>><br>> Don Brown wrote:<br>> > Cool! Good to hear you integrated it so quickly. Actually,<br>> I don't<br>> > use Netbeans at all, as those artifacts were left over from
<br>> Dave's<br>> > code. In fact, I've already spent some time cutting out the<br>> generated<br>> > GUI code in favor of that GriddedPanel class. Personally, I<br>> use vim
<br>> > and jEdit, although I'm trying Eclipse out for the first time<br>> with<br>> > this project. I've always actively avoided IDEs but the way this<br>> > project works so well with them, I'm giving them another chance.
<br>> ><br>> > Sure, all those changes sound fine. I'll send you the<br>> blogapps zip<br>> > and look over the changes tomorrow. The blogapps code isn't<br>> forked,
<br>> > just not released since Dave's book hasn't hit production yet.<br>> > Finally, I have been using the svn repo since you switched (thank<br>> > you!) so we should be on the same page.
<br>> ><br>> > Don<br>> ><br>> > On 1/19/06, *DM Smith* < <a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com</a><br>> <mailto:<a href="mailto:dmsmith555@yahoo.com">
dmsmith555@yahoo.com</a>><br>> > <mailto:<a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com</a> <mailto:<a href="mailto:dmsmith555@yahoo.com">dmsmith555@yahoo.com</a>>>><br>> wrote:
<br>> ><br>> > Don,<br>> ><br>> > I've checked in your code. The code that you have is most<br>> > excellent and<br>> > I am looking forward to putting it in front of users!
<br>> Thanks so<br>> > much for<br>> > your contribution! Once we have it ready for release, we'll<br>> > announce it<br>> > for people to look at it from the nightly and respond to
<br>> their<br>> > comments.<br>> > Then we'll release!<br>> ><br>> > I have made some simple changes to quite CheckStyle. We<br>> have it set up
<br>> > that if you run ant against build.xml in jsword-web that<br>> it will<br>> > build<br>> > all the projects related to BibleDesktop and also the<br>> web. And
<br>> > then run<br>> > a series of QA checks. You can do this from the command<br>> line in<br>> > the root<br>> > of jsword-web. The pertinent commands are:
<br>> > ant all (does a clean, build, install, check)<br>> > ant incremental (does a clean, build, install, check)<br>> > ant checkstyle (runs only checkstyle, but it only works
<br>> after a<br>> > build.)<br>> ><br>> > And I made two other changes. I already mentioned that I<br>> moved<br>> > code from<br>
> > StatusBar into Desktop. The other change was that I used<br>> a "Type safe<br>> > enumeration" pattern for the type of Blog, called<br>> appropriately
<br>> > BlogType.<br>> ><br>> > I hope that my changes and the huge refactoring job that<br>> I did,<br>> > did not<br>> > get in your way.
<br>> ><br>> > Below are some more things that probably should be done<br>> to make it<br>> > similar to the rest of the code.<br>> ><br>> > Don Brown wrote:
<br>> > > Cool, yeah, I've started doing the same, going through<br>> and cleaning<br>> > > things up. The GUI code has tons of errors for two<br>> main reasons:
<br>> > > * Still not 100% sure how you solve localization, so<br>> there are<br>> > a lot<br>> > > of labels and error messages still in the code<br>
> > As noted before, we use the Msg class for localization of<br>> messages. I<br>> > took care of that for you. I also marked strings that<br>> didn't need<br>> > to be
<br>> > localized.<br>> > As to error messages, we use the o.c.c.util.Reporter<br>> static informUser<br>> > methods. Listeners for ReporterEvents will then handle
<br>> the message<br>> > appropriately. So we never print exceptions to std err. See<br>> > o.c.b.desktop.DesktopActions for examples. We let<br>> listeners figure out
<br>> > the best way to communicate to the user. So we don't<br>> create and manage<br>> > dialog boxes on the fly.<br>> > > * Most of that code was forked from the Blogapps code,
<br>> where it<br>> > was a<br>> > > standalone Swing app.<br>> > In doing the connection, it appears that you are doing it<br>> in the main<br>
> > thread. We have a Job class and a Progress meter that we<br>> use for long<br>> > running background processes. See<br>> > o.c.j.book.install.sword.AbstractSwordInstaller
's<br>> install method<br>> > for a<br>> > good example. Also see the documentation for JobManager.<br>> ><br>> > I would appreciate it if you could provide
<br>> blogapps-1.0-src.zip.<br>> > Especially, if it is forked. In that case we may want to<br>> manage the<br>> > forked source.<br>> > > Furthermore, a lot of it was autogenerated by Netbeans.
<br>> > In localizing buttons, and other actionable things, we use<br>> > o.c.c.swing.CWActions and o.c.c.swing.ActionFactory and<br>> an action<br>> > property file. An example of this is
DesktopActions.java and<br>> > Desktop.properties. This is also a good example of<br>> splitting the<br>> > responsibility of a complex screen into two classes. One<br>> for the
<br>> > GUI and<br>> > the other for handling the events generated by that GUI.<br>> ><br>> > The basic idea is that an ActionFactory will read the<br>> property
<br>> > file and<br>> > construct CWAction objects. The ActionFactory will then<br>> dispense of<br>> > CWActions by name. Also the ActionFactory and the<br>
> CWAction work<br>> > together<br>> > to use reflection against a "bean" to call a "do" method<br>> constructed<br>> > using the name of the action.
<br>> ><br>> > The reason that I mention this is that I don't think it<br>> fits well with<br>> > Netbeans auto generated code. I left it alone so you<br>> could see if you
<br>> > could integrate it using NetBeans.<br>> ><br>> > In His Service,<br>> > DM<br>> ><br>> > _______________________________________________
<br>> > jsword-devel mailing list<br>> > <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>> <mailto:<a href="mailto:jsword-devel@crosswire.org">
jsword-devel@crosswire.org</a>><br>> <mailto:<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>> <mailto:<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org
</a>>><br>> > <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>> <<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">
http://www.crosswire.org/mailman/listinfo/jsword-devel</a>><br>> ><br>> ><br>> > ------------------------------------------------------------------------<br>> ><br>
> > _______________________________________________<br>> > jsword-devel mailing list<br>> > <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a> <mailto:<a href="mailto:jsword-devel@crosswire.org">
jsword-devel@crosswire.org</a>><br>> > <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>> <<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">
http://www.crosswire.org/mailman/listinfo/jsword-devel</a>><br>> ><br>> _______________________________________________<br>> jsword-devel mailing list<br>> <a href="mailto:jsword-devel@crosswire.org">
jsword-devel@crosswire.org</a> <mailto:<a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a>><br>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel
</a><br>> <<a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a>><br>><br>><br>><br>> ------------------------------------------------------------------------
<br>><br>> _______________________________________________<br>> jsword-devel mailing list<br>> <a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a><br>> <a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">
http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br>><br>_______________________________________________<br>jsword-devel mailing list<br><a href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a>
<br><a href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a><br></blockquote></div><br>