<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Joe,<br>
I had a look at your patch. I like where it is going. I like that
in the install dialog, the tabs are ordered in the order that they will
be used. I especially like the addition of the count at the top! It is
a small thing, but I don't think it is obvious from scrolling through
the list how much is available. The creation of the AbstractInstaller
has been really needed.<br>
<br>
Two small things (besides the problem you noted):<br>
The button that is labeled Install for Searching should be grayed out
if the selection is not a bible.<br>
<br>
In the InstallResolver you have:<br>
assert it.hasNext();<br>
installer = (Installer) it.next();<br>
<br>
There is a problem with this construct. If the production code is run
with assertions turned off then the assert line is never run. That is
it.hasNext() is not called.<br>
The assert line should never have side effects.<br>
<br>
You could do it as:<br>
boolean hasNext = it.hasNext();<br>
assert hasNext;<br>
installer = (Installer) it.next();<br>
<br>
I think I can work around your bugs. So I am not going to back out your
patches.<br>
<br>
Joe Walker wrote:
<blockquote cite="mid5dd47426041014161463b24f3e@mail.gmail.com"
type="cite">
<pre wrap="">I need to check-in my current work, which adds index download
functionality and alters the sites dialog a bit - there is a bug that
breaks http download and I've not had chance to fix it in the past few
days.
I say this just to avoid us breaking each-others work.
My solution was to have 2 buttons, "Install" and "Install with
Search". which could easily be adapted to generate rather than
download.
I've attached a patch so you can see where I was going. Just because
I've written some index download code doesn't mean we need to include
it.
Joe.
On Wed, 13 Oct 2004 22:05:24 -0400, DM Smith <a class="moz-txt-link-rfc2396E" href="mailto:dmsmith555@yahoo.com"><dmsmith555@yahoo.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I recently added a popup upon install that informs the user what the
download size of the module is. I think that it would be easy to add a
check box (that is not checked by default) to index the bible upon download.
I had not thought about it before, but I too have only indexed one or
two bibles.
Paul Price wrote:
</pre>
<blockquote type="cite">
<pre wrap="">OK, how about a popup when it notices new books (or a check box on the
download) that lets the user specify which books gets indexed (and some
explanation about indexing so the user doesn't get miffed)?
Like you, I would only search on particular versions (usually I know the
word I want, just not sure exactly where it is; the other mode would be
for word studies --- where does this particular word appear, and this I
would only do with a version I've chosen).
P.
</pre>
</blockquote>
<pre wrap="">_______________________________________________
jsword-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a>
</pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
jsword-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:jsword-devel@crosswire.org">jsword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/jsword-devel">http://www.crosswire.org/mailman/listinfo/jsword-devel</a>
</pre>
</blockquote>
</blockquote>
</body>
</html>