[jsword-devel] BibleDesktop source

Sun Jun 11 13:25:41 MST 2017

Excellent!  Thanks.

Martin

On 11 June 2017 at 01:22, DM Smith <dmsmith at crosswire.org> wrote:

> Fixed in SwordBookDriver.registerNewBook(sbmd) by loading the newly
> downloaded conf into a new sbmd and using that to construct the book loaded
> into the installed book list.
>
> DM Smith
>
> On Jun 10, 2017, at 4:00 PM, DM Smith <dmsmith at crosswire.org> wrote:
>
> The problem is in AbstractSwordInstaller lines 259-262:
>                 // TRANSLATOR: Progress label for installing the conf
> file for a book.
>                 job.setSectionName(JSMsg.gettext("Copying config file"));
>                 sbmd.setLibrary(NetUtil.getURI(dldir));
>                 SwordBookDriver.registerNewBook(sbmd);
>
> It actually doesn’t attempt to do what it says. The config file has been
> copied. The sbmd.setLibrary call is an attempt to take the mods.d.tar.gz
> entry and massage it enough to make it work. It isn’t sufficient. Still
> trying to figure out what should be done here.
>
> So, either we can load the new conf or massage the other enough to make it
> work.
>
> I’m thinking that it’d be safer to load it anew. If I figure out the n
> things that it needs that loading from file provides, who is to say that
> tomorrow loading won’t change and break it again.
>
> In Him,
> DM
>
> On May 29, 2017, at 5:13 PM, Martin Denham <mjdenham at gmail.com> wrote:
>
> .. or maybe you could derive the real conf name exactly from attributes in
> the partial sbmd, without iterating over mods.d, and load the correct conf
> immediately
>
> On 29 May 2017 at 21:49, Martin Denham <mjdenham at gmail.com> wrote:
>
>> Thanks DM, I could take a stab at a fix but I have not got a great
>> understanding of JSword at this level.
>>
>> It seems like, somewhere, we should
>>
>>    1. iterate over the mods.d folder and find the real .conf file
>>    matching the incomplete sbmd by matching initials or abbreviation
>>    2. generate a real sbmd from the real conf
>>    3. either just return the real sbmd or if part of install() then
>>    registerNewBook(realSbmd)
>>
>> Enjoy your holiday.
>>
>> Martin
>>
>> On 29 May 2017 at 19:09, DM Smith <dmsmith at crosswire.org> wrote:
>>
>>> I'm on holiday. Will look at it soon after.
>>>
>>> DM
>>>
>>> On May 29, 2017, at 9:40 AM, Martin Denham <mjdenham at gmail.com> wrote:
>>>
>>> I got BibleDesktop running locally and it has the same problem.
>>>
>>> 1. Run BibleDesktop
>>> 2. Install a new module e.g. Darby
>>> 3. View 'Installed Books'
>>> 4. Select the new book e.g. Darby
>>> 5. Cannot delete because the 'Delete Book' button is disabled due to the
>>> same issue as above
>>>
>>> Martin
>>>
>>> On 28 May 2017 at 15:20, Martin Denham <mjdenham at gmail.com> wrote:
>>>
>>>> Yes, are you aware of any way to tell JSword to load the real conf file
>>>> rather than the buffer extracted from mods.d.tar.gz?  I have looked around
>>>> but can't see any way.
>>>>
>>>> Martin
>>>>
>>>> On 28 May 2017 at 03:59, DM Smith <dmsmith at crosswire.org> wrote:
>>>>
>>>>> Sorry for the late response.
>>>>>
>>>>> While we have moved JSword to git, BibleDesktop is still in SVN. You
>>>>> can find the info on this page: http://www.crosswire.org
>>>>> /jsword/svn.html The page hasn’t been updated since we moved JSword
>>>>> to git, but it is still accurate wrt BibleDesktop.
>>>>>
>>>>> Looking briefly the basic issue is that when we load a conf from
>>>>> mods.d.tar.gz we are loading a buffer not reading the file from disk.
>>>>>
>>>>> Hope this helps,
>>>>> DM Smith
>>>>>
>>>>> On May 27, 2017, at 6:36 PM, Martin Denham <mjdenham at gmail.com> wrote:
>>>>>
>>>>> I was actually hoping to dive into BibleDesktop in the hope of finding
>>>>> a solution to JS-282
>>>>> <http://tracker.crosswire.org/projects/JS/issues/JS-282>.  I saw some
>>>>> BibleDesktop source in a couple of places but neither looked very official,
>>>>> so that is why I asked.
>>>>>
>>>>> However, if anybody can suggest a possible solution for JS-282
>>>>> <http://tracker.crosswire.org/projects/JS/issues/JS-282> I would be
>>>>> very thankful and would not need to analyse BD.
>>>>>
>>>>> Martin
>>>>>
>>>>> On 22 April 2017 at 23:32, Martin Denham <mjdenham at gmail.com> wrote:
>>>>>
>>>>>> Where is the latest BibleDesktop source stored?
>>>>>>
>>>>>> Martin
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jsword-devel mailing list
>>>>> jsword-devel at crosswire.org
>>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jsword-devel mailing list
>>>>> jsword-devel at crosswire.org
>>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>>>
>>>>>
>>>>
>>> _______________________________________________
>>> jsword-devel mailing list
>>> jsword-devel at crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>
>>>
>>> _______________________________________________
>>> jsword-devel mailing list
>>> jsword-devel at crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>
>>>
>>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20170611/91477e8c/attachment.html>