[jsword-devel] new eBible repo testing

DM Smith dmsmith at crosswire.org
Wed Sep 30 14:30:45 MST 2015 

Sorry I didn’t say. I checked it in. Let me know if there’s something else that needs to be added to make Abbreviation useful.

— DM

> On Sep 30, 2015, at 5:15 PM, Martin Denham <mjdenham at gmail.com> wrote:
> 
> Hi DM,
> 
> How are you getting on with the fix?
> 
> Cheers
> Martin
> 
> On 22 September 2015 at 07:50, Peter von Kaehne <refdoc at gmx.net <mailto:refdoc at gmx.net>> wrote:
> To add to that there is of course the time honoured way of avoiding clobbering by adding a counter to a file name when things preexist. Maybe the installer could be made to add clobber preventing counters to Abbreviation and the user can then improve upon that. If they want to.
> 
> Peter
> 
> Sent from my phone. Apologies for brevity and typos.On 22 Sep 2015 01:26, DM Smith <dmsmith at crosswire.org <mailto:dmsmith at crosswire.org>> wrote:
> >
> > Peter,
> > You are spot-on.
> >
> > I’d add, that for people that use an English Bible (e.g. KJV, ESV, WEB, NET, ...) in parallel to their local language, it is important that there isn’t an app clumsiness handling a clash.
> >
> > Note: The Thai KJV module in eBible repo now has an Abbreviation of ThaKJV.
> >
> > I was trying to make a change in the shared code (JSword) that would just work in the frontends (e.g. AndBible, BibleDesktop, STEP, …) without change. It was naive.
> >
> > DM
> >
> > > On Sep 21, 2015, at 6:36 PM, Peter von Kaehne <refdoc at gmx.net <mailto:refdoc at gmx.net>> wrote:
> > >
> > > Hi Martin,
> > >
> > > Just to be clear:
> > >
> > > The ModuleName remains the unique identifier for each module. We have
> > > introduced some changes how they are constructed for eBible to avoid an
> > > ever lengthening number of clashes of duplicates. eBible has a lot of
> > > texts we have too - and then it has 100s more. We are interested in teh
> > > 100s more, while we wanted to avoid too much grief from the duplicates.
> > >
> > > Hence the addition of a repo-identifier to the Modulename - which now
> > > becomes even more meaningless to users.
> > >
> > > So this is where Abbreviation comes in. But - Abbreviation does not
> > > need to be unique across all offered 1000s of bibles - just unique
> > > within a single user install. Thais call one of their Bibles apparently
> > > KJV - presumably because it is translated from that and that should be
> > > fine as long as no other KJV is installed. Then a solution must be
> > > found.
> > >
> > > So, if you want to use Abbreviation you need to ensure
> > >
> > > a) That ModuleName remains the internally used unique identifier
> > > b) that the app offers some option to resolve Abbreviation clashes. The
> > > user must be able to determine in the end how he wants his modules
> > > called and how he wants conflicts resolved, preferentially without fall
> > > back to a visible ModuleName - because they are now unreadable and will
> > > appear more or less meaningless to users.
> > >
> > > This solution has been discussed extensively on sword-devel and this is
> > > the best what we came up with.
> > >
> > > Peter
> > >
> > > On Mon, 2015-09-21 at 23:11 +0100, Martin Denham wrote:
> > >> Thanks for finding the problem.  How long do you think before a fix
> > >> is available?  I could go back to a pre-abbreviation version or
> > >> temporarily revert to the build AB was using before which is about 6
> > >> months old?  Maybe it wasn't such a good time to take a new version
> > >> of JSword.  AB won't be using the ebible repo immediately.
> > >>
> > >> I don't anticipate big issues if everything was as it was before with
> > >> the addition of getAbbreviation() which could be handled in the front
> > >> end.  Maybe a new method, something like, getDisplayName() which has
> > >> a little logic to determine if initials, abbreviation, or description
> > >> is best used in the ui, but I haven't thought that through
> > >> thoroughly.
> > >>
> > >> There seem to be some fundamental changes in standards adopted by the
> > >> ebible repo.  I have not worked out the affect of them yet and did
> > >> not follow all the discussion, but personally felt that it would have
> > >> been simpler if it had adopted standards that were more similar to
> > >> other repos.  However, I don't think it will be too difficult to make
> > >> the ebible repo available via AB.
> > >>
> > >> Cheers
> > >> Martin
> > >>
> > >>
> > >> On 19 September 2015 at 21:16, DM Smith <dmsmith at crosswire.org <mailto:dmsmith at crosswire.org>>
> > >> wrote:
> > >>> I had made getInitials return the abbreviation if there was one.
> > >>> And I had added getInternalName to return what getInitials used to
> > >>> be. I did this in BookMetaData but didn’t do something comparable
> > >>> in Book.
> > >>>
> > >>> It was bad to have changed the contract of getInitials. So I’m
> > >>> reverting that change. I’m adding getAbbreviation which will return
> > >>> the abbreviation if any and the initials otherwise. Hopefully, no
> > >>> one has used getInternalName yet. I’d rather drop it than deprecate
> > >>> it.
> > >>>
> > >>> I was trying to make it such that front-ends didn’t need to change
> > >>> to support Abbreviations.
> > >>>
> > >>> The remaining challenge regards sorting of book lists visible to
> > >>> users. They should either be sorted on what the user sees. So far
> > >>> they have either seen Initials or Descriptions. But now it should
> > >>> be Abbreviations or Descriptions.
> > >>>
> > >>> The other problem is that in the eBible repository has defined
> > >>> uniqueness of abbreviations to be within a language. The assumption
> > >>> is that a user will not install books in different languages. But
> > >>> we have to have a deterministic sort order.
> > >>>
> > >>> The other problem regards lookup. Adding Abbreviation into the
> > >>> search is a complication.
> > >>>
> > >>> — DM
> > >>>
> > >>>> On Sep 19, 2015, at 1:50 PM, DM Smith <dmsmith at crosswire.org <mailto:dmsmith at crosswire.org>>
> > >>>> wrote:
> > >>>>
> > >>>> It’s due to adding support for Abbreviation. There’s a bug in
> > >>>> computing the zip file name.
> > >>>>
> > >>>> For example Hindi ERV should try to download HinERV.zip but
> > >>>> instead it is HindiERV.zip.
> > >>>>
> > >>>> It has:
> > >>>> [HinERV]
> > >>>> Abbreviation=HindiERV
> > >>>>
> > >>>> Working on a fix.
> > >>>>
> > >>>> In Him,
> > >>>> DM
> > >>>>
> > >>>>> On Sep 18, 2015, at 1:44 PM, DM Smith <dmsmith at crosswire.org <mailto:dmsmith at crosswire.org>>
> > >>>>> wrote:
> > >>>>>
> > >>>>> I'll look this weekend to see what I can find.
> > >>>>>
> > >>>>> Cent from my fone so theer mite be tipos. ;)
> > >>>>>
> > >>>>> On Sep 17, 2015, at 5:43 PM, Martin Denham <mjdenham at gmail.com <mailto:mjdenham at gmail.com>>
> > >>>>> wrote:
> > >>>>>
> > >>>>>> I think this problem and other related problems in And Bible
> > >>>>>> might be related to the new version of JSword because I am
> > >>>>>> also having problems with certain books from other repos.
> > >>>>>>
> > >>>>>> Since upgrading to the latest version of JSword I am seeing
> > >>>>>> unzip problems with certain files e.g. HindiERV, СПВП, and
> > >>>>>> many from eBible.
> > >>>>>>
> > >>>>>> Also, one user has found that foreign characters in the conf
> > >>>>>> Description field prevent previously installed modules
> > >>>>>> loading.  Coincidentally all the above modules have foreign
> > >>>>>> characters in their description field.  Does anybody recall a
> > >>>>>> change in this area during the last 6 months, which was the
> > >>>>>> time since my last build of jsword?
> > >>>>>>
> > >>>>>> The error I get when attempting to install a zip is:
> > >>>>>>
> > >>>>>> Not a zip archive
> > >>>>>> java.util.zip.ZipException: Not a zip archive
> > >>>>>> at java.util.zip.ZipFile.readCentralDir(ZipFile.java:385)
> > >>>>>> at java.util.zip.ZipFile.<init>(ZipFile.java:163)
> > >>>>>> at java.util.zip.ZipFile.<init>(ZipFile.java:119)
> > >>>>>> at org.crosswire.common.util.IOUtil.unpackZip(IOUtil.java:86)
> > >>>>>> at
> > >>>>>> org.crosswire.jsword.book.install.sword.AbstractSwordInstalle
> > >>>>>> r.install(AbstractSwordInstaller.java:241)
> > >>>>>> at
> > >>>>>> net.bible.service.download.DownloadManager$1.run(DownloadMana
> > >>>>>> ger.java:135)
> > >>>>>>
> > >>>>>> I need to do more investigation but wondered if anybody had
> > >>>>>> any ideas regarding this problem.
> > >>>>>>
> > >>>>>> Can the above modules be installed without problems in
> > >>>>>> BibleDesktop?
> > >>>>>>
> > >>>>>> Thanks
> > >>>>>> Martin
> > >>>>>>
> > >>>>>> On 16 September 2015 at 13:26, DM Smith <
> > >>>>>> dmsmith at crosswire.org <mailto:dmsmith at crosswire.org>> wrote:
> > >>>>>>> I haven’t gotten to it. Other than a file here or there.
> > >>>>>>> And mods.d.tar.gz. I’ve been frustrated by how much churn
> > >>>>>>> it has had. And that nearly every module had some kind of
> > >>>>>>> problem. I hope to look at the zip problem this weekend.
> > >>>>>>>
> > >>>>>>> I was going to work it into the release of BibleDesktop
> > >>>>>>> (very soon). But now am thinking a follow-on release.
> > >>>>>>>
> > >>>>>>> — DM
> > >>>>>>>
> > >>>>>>>> On Sep 16, 2015, at 8:21 AM, Martin Denham <
> > >>>>>>> mjdenham at gmail.com <mailto:mjdenham at gmail.com>> wrote:
> > >>>>>>>>
> > >>>>>>>> Has anybody else been testing the new eBible repo with
> > >>>>>>> the JSword library?  I have had and am having various
> > >>>>>>> problems.
> > >>>>>>>>
> > >>>>>>>> Martin
> > >>>>>>>> _______________________________________________
> > >>>>>>>> jsword-devel mailing list
> > >>>>>>>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>>>>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> _______________________________________________
> > >>>>>>> jsword-devel mailing list
> > >>>>>>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>>>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>>>>>
> > >>>>>> _______________________________________________
> > >>>>>> jsword-devel mailing list
> > >>>>>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>>> _______________________________________________
> > >>>>> jsword-devel mailing list
> > >>>>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>> _______________________________________________
> > >>>> jsword-devel mailing list
> > >>>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>
> > >>> _______________________________________________
> > >>> jsword-devel mailing list
> > >>> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >>> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >>>
> > >> _______________________________________________
> > >> jsword-devel mailing list
> > >> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > >> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> > >
> > >
> > > _______________________________________________
> > > jsword-devel mailing list
> > > jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > > http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> >
> > _______________________________________________
> > jsword-devel mailing list
> > jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> > http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
> http://www.crosswire.org/mailman/listinfo/jsword-devel <http://www.crosswire.org/mailman/listinfo/jsword-devel>
> 
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20150930/db28266a/attachment-0001.html>

More information about the jsword-devel mailing list