[jsword-devel] Pull requests
DM Smith
dmsmith at crosswire.org
Wed Jan 15 18:43:21 MST 2014
Done. Enjoy. Thanks Chris for the v11n mapping code! I'm looking forward to using it.
In Him,
DM
On Jan 15, 2014, at 12:50 PM, DM Smith <dmsmith at crosswire.org> wrote:
> I should be able to do it tonight. No reservations. Haven't had time.
>
> After the pull request, we should plan a release for it and tag it as such. It is a major change. So if we can incorporate it into our code bases, making necessary changes to it, that'd be great.
>
> In Him,
> DM
> On Jan 15, 2014, at 12:47 PM, Martin Denham <mjdenham at gmail.com> wrote:
>
>> How are we getting on with the final pull request. Are there any specific reservations about the v11n mapping code or does it just need a bit more time to review.
>>
>> And Bible is in a state of flux atm so it would be a good time to try out the new mapping code.
>>
>> Martin
>>
>>
>> On 11 January 2014 13:58, Chris Burrell <chris at burrell.me.uk> wrote:
>> What breaking change is that? Not sure I know about that... ?
>>
>> Chris
>>
>>
>>
>> On 11 January 2014 13:39, DM Smith <dmsmith at crosswire.org> wrote:
>> I think we need to nail the release process and branching. The purpose of tags and branches is to provide stability and allow frequent releases.
>>
>> From memory, Chris had a breaking change that he incorporated into STEP. This needs to be handled well.
>>
>> At this point I'll adjust BD for any commits that we decide upon, even if disruptive. So wearing my BD hat, I'm cool with any or all of the pull requests. I think Tonny is the same w/ AlKitab.
>>
>> So, And Bible and STEP (Martin and Chris) need to agree on what is to be committed.
>>
>> I'm happy to open commit privs to the two of you. Normal caveats apply. ;)
>>
>> I have this weekend available to work on this.
>>
>> In Him,
>> DM
>>
>> On Jan 10, 2014, at 6:16 PM, Chris Burrell <chris at burrell.me.uk> wrote:
>>
>>> +1 one that - happy to do some reviews if that would be helpful. There are a few of mine too, and I'd like to do a diff against the JSword repo and STEP version of the JSword repo, to bring them both inline (as the network graph will suggest, they have diverged quite a bit).
>>>
>>>
>>> Chris
>>>
>>>
>>>
>>> On 10 January 2014 22:49, Martin Denham <mjdenham at gmail.com> wrote:
>>> Could I ask what the status is regarding pull requests. There is quite a backlog.
>>>
>>> Thanks
>>> Martin
>>>
>>>
>>>
>>> _______________________________________________
>>> jsword-devel mailing list
>>> jsword-devel at crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>
>>>
>>> _______________________________________________
>>> jsword-devel mailing list
>>> jsword-devel at crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>
>>
>>
>> _______________________________________________
>> jsword-devel mailing list
>> jsword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>
>>
>> _______________________________________________
>> jsword-devel mailing list
>> jsword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20140115/8095ce33/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4145 bytes
Desc: not available
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20140115/8095ce33/attachment.p7s>
More information about the jsword-devel
mailing list