[jsword-devel] Pull requests

[DM Smith]

If you can, put it first, followed by a space or new line.
I don't know if it can be elsewhere. We used to have a SVN plugin in Jira that would grab the commit and show the code related to the issue. It did this by periodically searching the log messages.

DM

On Apr 25, 2013, at 12:36 PM, Martin Denham <mjdenham at gmail.com> wrote:

> Can you remind me - is it sufficient to put the Jira bug number e.g. JS-123 in the commit text or does it need to be in a special position or format in the commit?
> 
> Martin
> 
> 
> On 25 April 2013 17:25, DM Smith <dmsmith at crosswire.org> wrote:
> 
> On Apr 25, 2013, at 12:24 PM, Martin Denham <mjdenham at gmail.com> wrote:
> 
> > Is there any problem preventing the Pull requests being applied.  I am trying to eliminate 'tweaks' to JSword in And Bible (as much as possible) and there are a couple more small 'tweaks' I would like to Push but previous Pull requests have been sitting there a few weeks and I wondered if something was wrong.
> 
> I haven't had the time. I should have time this weekend.
> 
> >
> > btw should we still add a reference to the JIRA bug in the commit comments to link the commit to a bug in JIRA.
> 
> Yes please.
> 
> >
> > Martin
> > _______________________________________________
> > jsword-devel mailing list
> > jsword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/jsword-devel
> 
> 
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
> 
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20130425/a889413d/attachment.html>