[jsword-devel] [JIRA] Commented: (JS-213) Missing code in thml.ATag causes missing osisRef attribute in reference

[Martin Denham (JIRA)]

    [ http://www.crosswire.org/bugs/browse/JS-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24571#comment-24571 ] 

Martin Denham commented on JS-213:
----------------------------------

Hi DM,

Now I am a bit confused.  I had googled "Sword URI" to find the standard approach to take and came up with the following pages:

    http://www.crosswire.org/wiki/Frontends:URI_Standard
    http://www.mail-archive.com/sword-devel@crosswire.org/msg20670.html

that seemed to suggest that sword://module/key is a Sword standard.

I also though the url handling would be done in the front ends rather than in JSword.  How would I change JSword code to add a sword:// protocol handler?

Kind regards
Martin

> Missing code in thml.ATag causes missing osisRef attribute in reference
> -----------------------------------------------------------------------
>
>                 Key: JS-213
>                 URL: http://www.crosswire.org/bugs/browse/JS-213
>             Project: JSword
>          Issue Type: Bug
>          Components: o.c.jsword.book.filter.thml
>            Reporter: Martin Denham
>            Assignee: DM Smith
>            Priority: Minor
>         Attachments: ATag.java, ATagTest.java
>
>
> I believe there is some missing code in thml.ATag.  In StrongsRealGreek there are references like:
>    <a href="sword://StrongsRealGreek/01909">1909</a>
> and the above is currently converted to OSIS as:
>    <reference>1909</reference>
> However I think it should be:
>    <reference osisRef="sword://StrongsRealGreek/01909">1909</reference>
> Joe has left the following comment in ATag which seems to confirm that some code is missing:
>    // LATER(joe): put the correct reference here
> I added the following just before Joe's comment which seems to fix the problem:
>         String href = attrs.getValue("href");
>         if (href!=null && !href.isEmpty()) {
>             reference.setAttribute(OSISUtil.OSIS_ATTR_REF, href);
>         }
> I will attach the amended ATag.java and also a junit test.  If nobody comments adversely before next week then I can check in the junit and fixed code next week.
> There is probably also an issue with xml like "<a name="01993">1993</a>" which is not addressed by the attached fix.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira