[jsword-devel] [JIRA] Created: (JS-200) Book name lookup errors

[Martin Denham (JIRA)]

Book name lookup errors
-----------------------

                 Key: JS-200
                 URL: http://www.crosswire.org/bugs/browse/JS-200
             Project: JSword
          Issue Type: Bug
          Components: o.c.jsword.versification
    Affects Versions: 1.6.1
            Reporter: Martin Denham
            Assignee: DM Smith
            Priority: Blocker
         Attachments: BookName.patch

Here is an example
  Locale.setDefault(Locale.GERMAN);
  System.out.println(BibleBook.getBook("Mr")); //returns PrAzar instead of Mark

The foreign language versions of BibleNames.properties mainly have blank entries for the new book names e.g.
Tob.Full=
Tob.Short=
Tob.Alt=

This means the following code in BookName.java
  if (normalizedShortName.startsWith(normalizedName) || normalizedName.startsWith(normalizedShortName)) {
must be changed to:
  if (normalizedShortName.startsWith(normalizedName) || (normalizedShortName.length()>0 && normalizedName.startsWith(normalizedShortName))) {

On a related note I do not think we should have blank property file entries for the new books in any file other than the single default BibleName.properties because this will prevent anything being displayed and prevent correct display of the default property value.  A German speaker would rather see 'Tobit' than ''.

I have attached a patch file.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira