[jsword-devel] [JIRA] Updated: (JS-110) Module Version number validation is too strict

[DM Smith (JIRA)]

     [ http://www.crosswire.org/bugs/browse/JS-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

DM Smith updated JS-110:
------------------------

    Fix Version/s: 1.6.1

> Module Version number validation is too strict
> ----------------------------------------------
>
>                 Key: JS-110
>                 URL: http://www.crosswire.org/bugs/browse/JS-110
>             Project: JSword
>          Issue Type: Bug
>          Components: o.c.jsword.book
>            Reporter: Martin Denham
>            Assignee: DM Smith
>            Priority: Minor
>             Fix For: 1.6.1
>
>
> Some modules like ESV no longer have a simple version number that can be represented as a float so the version number validation fails.  I think that version number could in theory contain anything and so it may be better to remove the validation as in the following patch.  The reason this affects me is because the plan is to include the module version number in the index download file name, as do PocketSword index downloads:
> Index: ConfigEntryType.java
> ===================================================================
> --- ConfigEntryType.java	(revision 1999)
> +++ ConfigEntryType.java	(working copy)
> @@ -620,13 +620,7 @@
>      public static final ConfigEntryType VERSION = new ConfigEntryType("Version", "1.0") {
>  
>          public boolean isAllowed(String aValue) {
> -            try {
> -                Float.parseFloat(aValue);
> -                return true;
> -            } catch (NumberFormatException e) {
> -                return false;
> -            }
> -
> +            return true;
>          }
>  
>          /**

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira