[jsword-devel] [JIRA] Commented: (JS-184) Change BibleNames to be an enum
DM Smith (JIRA)
jira at crosswire.org
Sun Apr 3 04:53:46 MST 2011
[ http://www.crosswire.org/bugs/browse/JS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970#comment-14970 ]
DM Smith commented on JS-184:
I've checked in the first pass of changes.
See the "Subversion Commits" tab for the changes.
> Change BibleNames to be an enum
> Key: JS-184
> URL: http://www.crosswire.org/bugs/browse/JS-184
> Project: JSword
> Issue Type: Sub-task
> Components: o.c.jsword.book
> Affects Versions: 1.6
> Reporter: DM Smith
> Assignee: DM Smith
> Fix For: 1.6.1
> BibleNames currently is a set of constants numbering the books of the Bible from 1 to 66, from Genesis to Revelation.
> This poses two problems to alternate versification:
> * These numbers are often used as indexes into arrays. This presumes that the KJV ordering of the books is what every v11n uses. Not so.
> * The range precludes apocryphal/deuterocanonical books.
> For details, see: http://crosswire.org/wiki/OSIS_Book_Abbreviations
> The av11n implementation in SWORD allows for books to be in any order and for "additional" books to be in either the OT or NT data files. It did not add a third set of data files.
> By having an enum of the books we can pass around a BibleBook object.
> The impact of this change is significant. Probably the most significant is the Verse class.
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jsword-devel